Fix lumina offset for WorldSheet

LightlessSync/LightlessSync.csproj

@@ -24,6 +24,15 @@
     <Compile Remove="PlayerData\Export\**" />
     <EmbeddedResource Remove="PlayerData\Export\**" />
     <None Remove="PlayerData\Export\**" />
+    <EmbeddedResource Update="Resources\Resources.resx">
+      <Generator>PublicResXFileCodeGenerator</Generator>
+      <LastGenOutput>Resources.Designer.cs</LastGenOutput>
+    </EmbeddedResource>
+    <Compile Update="Resources\Resources.Designer.cs">
+      <DesignTime>True</DesignTime>
+      <AutoGen>True</AutoGen>
+      <DependentUpon>Resources.resx</DependentUpon>
+    </Compile>
   </ItemGroup>
 
   <ItemGroup>
@@ -68,8 +77,6 @@
     </None>
     <EmbeddedResource Include="Changelog\changelog.yaml" />
     <EmbeddedResource Include="Changelog\credits.yaml" />
-    <EmbeddedResource Include="Localization\de.json" />
-    <EmbeddedResource Include="Localization\fr.json" />
   </ItemGroup>
 
   <ItemGroup>

LightlessSync/LightlessSync.csproj.DotSettings

@@ -0,0 +1,3 @@
+<wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
+	<s:String x:Key="/Default/CodeEditing/Localization/Localizable/@EntryValue">Yes</s:String>
+	<s:String x:Key="/Default/CodeEditing/Localization/LocalizableInspector/@EntryValue">Pessimistic</s:String></wpf:ResourceDictionary>

LightlessSync/Localization/Strings.cs

@@ -1,44 +0,0 @@
-using CheapLoc;
-
-namespace LightlessSync.Localization;
-
-public static class Strings
-{
-    public static ToSStrings ToS { get; set; } = new();
-
-    public class ToSStrings
-    {
-        public readonly string AgreeLabel = Loc.Localize("AgreeLabel", "I agree");
-        public readonly string AgreementLabel = Loc.Localize("AgreementLabel", "Agreement of Usage of Service");
-        public readonly string ButtonWillBeAvailableIn = Loc.Localize("ButtonWillBeAvailableIn", "'I agree' button will be available in");
-        public readonly string LanguageLabel = Loc.Localize("LanguageLabel", "Language");
-
-        public readonly string Paragraph1 = Loc.Localize("Paragraph1",
-            "All of the mod files currently active on your character as well as your current character state will be uploaded to the service you registered yourself at automatically. " +
-            "The plugin will exclusively upload the necessary mod files and not the whole mod.");
-
-        public readonly string Paragraph2 = Loc.Localize("Paragraph2",
-            "If you are on a data capped internet connection, higher fees due to data usage depending on the amount of downloaded and uploaded mod files might occur. " +
-            "Mod files will be compressed on up- and download to save on bandwidth usage. Due to varying up- and download speeds, changes in characters might not be visible immediately. " +
-            "Files present on the service that already represent your active mod files will not be uploaded again.");
-
-        public readonly string Paragraph3 = Loc.Localize("Paragraph3",
-            "The mod files you are uploading are confidential and will not be distributed to parties other than the ones who are requesting the exact same mod files. " +
-            "Please think about who you are going to pair since it is unavoidable that they will receive and locally cache the necessary mod files that you have currently in use. " +
-            "Locally cached mod files will have arbitrary file names to discourage attempts at replicating the original mod.");
-
-        public readonly string Paragraph4 = Loc.Localize("Paragraph4",
-            "The plugin creator tried their best to keep you secure. However, there is no guarantee for 100% security. Do not blindly pair your client with everyone.");
-
-        public readonly string Paragraph5 = Loc.Localize("Paragraph5",
-            "Mod files that are saved on the service will remain on the service as long as there are requests for the files from clients. " +
-            "After a period of not being used, the mod files will be automatically deleted. " +
-            "You will also be able to wipe all the files you have personally uploaded on request. " +
-            "The service holds no information about which mod files belong to which mod.");
-
-        public readonly string Paragraph6 = Loc.Localize("Paragraph6",
-            "This service is provided as-is. In case of abuse join the Lightless Sync Discord.");
-
-        public readonly string ReadLabel = Loc.Localize("ReadLabel", "READ THIS CAREFULLY");
-    }
-}

LightlessSync/Localization/de.json

@@ -1,46 +0,0 @@
-{
-  "LanguageLabel": {
-    "message": "Language",
-    "description": "ToSStrings..ctor"
-  },
-  "AgreementLabel": {
-    "message": "Nutzungsbedingungen",
-    "description": "ToSStrings..ctor"
-  },
-  "ReadLabel": {
-    "message": "BITTE LIES DIES SORGFÄLTIG",
-    "description": "ToSStrings..ctor"
-  },
-  "Paragraph1": {
-    "message": "Alle Moddateien, die aktuell auf deinem Charakter aktiv sind und dein Charakterzustand werden automatisch zu dem Service, an dem du dich registriert hast, hochgeladen. Das Plugin wird ausschließlich die nötigen Moddateien hochladen und nicht die gesamte Modifikation.",
-    "description": "ToSStrings..ctor"
-  },
-  "Paragraph2": {
-    "message": "Falls du mit einer getakteten Internetverbindung verbunden bist, können durch den Datentransfer von Hoch- und Runtergeladenen Moddateien höhere Kosten entstehen. Moddateien werden beim Hoch- und Runterladen komprimiert um Bandbreite zu sparen. Durch unterschiedliche Hoch- und Runterladgeschwindigkeiten ist es möglich, dass Änderungen an Charakteren nicht sofort sichtbar sind. Dateien die bereits auf dem Service existieren, werden nicht nochmals hochgeladen.",
-    "description": "ToSStrings..ctor"
-  },
-  "Paragraph3": {
-    "message": "Die Moddateien die du hochlädst sind vertraulich und werden nicht mit anderen Nutzern geteilt, die nicht die exakt selben Dateien anfordern. Bitte überlege dir sorgfältig mit wem du deinen Identifikationscode teilst, da es unvermeidlich ist, dass die andere Person deine Moddateien erhält und lokal zwischenspeichert. Lokal zwischengespeicherte Dateien haben willkürrliche Namen um vor Versuchen abzuschrecken die originalen Moddateien aus diesen wiederherzustellen.",
-    "description": "ToSStrings..ctor"
-  },
-  "Paragraph4": {
-    "message": "Der Ersteller des Plugins hat sein Bestes getan, um deine Sicherheit zu gewährleisten. Es gibt jedoch keine Garantie für 100%ige Sicherheit. Teile deinen Identifikationscode nicht blind mit jedem.",
-    "description": "ToSStrings..ctor"
-  },
-  "Paragraph5": {
-    "message": "Moddateien, die auf dem Service gespeichert sind, verbleiben auf dem Service, solange es Anforderungen für diese Dateien gibt. Nach einer Zeitspanne in der die Dateien nicht verwendet wurden, werden diese automatisch gelöscht. Du hast auch die Möglichkeit manuell alle Dateien auf dem Service zu löschen. Der Service hat keine Informationen welche Moddateien zu welcher Modifikation gehören.",
-    "description": "ToSStrings..ctor"
-  },
-  "Paragraph6": {
-    "message": "Dieser Dienst wird ohne Gewähr angeboten. Im Falle eines Missbrauchs tretet dem Lightless Sync Discord bei.",
-    "description": "ToSStrings..ctor"
-  },
-  "AgreeLabel": {
-    "message": "Ich Stimme zu",
-    "description": "ToSStrings..ctor"
-  },
-  "ButtonWillBeAvailableIn": {
-    "message": "\"Ich stimme zu\" Knopf verfügbar in",
-    "description": "ToSStrings..ctor"
-  }
-}

LightlessSync/Localization/fr.json

@@ -1,46 +0,0 @@
-{
-  "LanguageLabel": {
-    "message": "Language",
-    "description": "ToSStrings..ctor"
-  },
-  "AgreementLabel": {
-    "message": "Conditions d'Utilisation",
-    "description": "ToSStrings..ctor"
-  },
-  "ReadLabel": {
-    "message": "LISEZ CES INFORMATIONS ATTENTIVEMENT",
-    "description": "ToSStrings..ctor"
-  },
-  "Paragraph1": {
-    "message": "Tous les fichiers moddés actuellement en cours d'utilisation ainsi que le statut actuel de votre personnage vont être mix en ligne via le service sur lequel vous vous êtes automatiquement enregistré. Seuls les fichiers nécessaires seront téléversés par le plugin et non pas le mod en entier.",
-    "description": "ToSStrings..ctor"
-  },
-  "Paragraph2": {
-    "message": "Si le débit de votre connexion internet est limité, le téléchargement et téléversement d'un grand nombre de fichiers peut entraîner des coûts supplémentaires. Les fichiers seront compressés au chargement et versement pour réduire l'impact sur votre bande passants. Selon la rapidité de vos téléchargements et téléversements, les changements ne seront peut-être pas visibles instantanément sur les personnages. Les fichiers déja présents sur le service qui correspondent à ceux de vos mods en cours d'utilisation ne seront pas remis en ligne.",
-    "description": "ToSStrings..ctor"
-  },
-  "Paragraph3": {
-    "message": "Les fichiers que vous allez partager sont confidentiels et ne seront envoyés qu'aux utilisateurs qui feront une requête exacte de ceux-çi. Nous vous demandons de (re)considérer qui sera synchronisé avec vous, puisqu'ils recevront et stockeront inévitablement en local les fichiers nécéssaires utilisés à cet instant. Les noms des fichiers stockés localement sont changés de manière arbitraire afin de décourager toute tentative de réplication des originaux.",
-    "description": "ToSStrings..ctor"
-  },
-  "Paragraph4": {
-    "message": "Le créateur de ce plugin a tenté de sécuriser l'application du mieux possible. Cependant, il ne peut pas garantir une protection 100% infaillible. Pour votre sécurité, ne vous synchronisez pas aveuglément et avec n'importe qui.",
-    "description": "ToSStrings..ctor"
-  },
-  "Paragraph5": {
-    "message": "Les fichiers sauvegardés sur le service resteront en ligne tant que des utilisateurs en feront usage. Ils seront effacés automatiquement après une certaine période d'inactivité. Vous pouvez également demander l'effacement de tous les fichiers que vous avez mis en ligne vous-même. Le service en soi ne contient aucune information pouvant identifier quel fichier appartient à quel mod.",
-    "description": "ToSStrings..ctor"
-  },
-  "Paragraph6": {
-    "message": "Ce service et ses composants vous sont fournis en l'état. En cas d'abus rejoindre le serveur Discord Lightless Sync.",
-    "description": "ToSStrings..ctor"
-  },
-  "AgreeLabel": {
-    "message": "J'accept",
-    "description": "ToSStrings..ctor"
-  },
-  "ButtonWillBeAvailableIn": {
-    "message": "Bouton \"J'accept\" disposible dans",
-    "description": "ToSStrings..ctor"
-  }
-}

LightlessSync/PlayerData/Factories/PlayerDataFactory.cs

@@ -1,4 +1,5 @@
-using FFXIVClientStructs.FFXIV.Client.Game.Character;
+using Dalamud.Utility;
+using FFXIVClientStructs.FFXIV.Client.Game.Character;
 using LightlessSync.API.Data.Enum;
 using LightlessSync.FileCache;
 using LightlessSync.Interop.Ipc;
@@ -11,6 +12,8 @@ using LightlessSync.Services.Mediator;
 using Microsoft.Extensions.Logging;
 using System.Collections.Concurrent;
 using System.Diagnostics;
+using System.Runtime.ExceptionServices;
+using System.Runtime.InteropServices;
 
 namespace LightlessSync.PlayerData.Factories;
 
@@ -123,22 +126,38 @@ public class PlayerDataFactory
     {
         if (playerPointer == IntPtr.Zero)
             return true;
+
+        if (!IsPointerValid(playerPointer))
+            return true;
+
+        var character = (Character*)playerPointer;
+        if (character == null)
+            return true;
+
+        var gameObject = &character->GameObject;
+        if (gameObject == null)
+            return true;
+
+        if (!IsPointerValid((IntPtr)gameObject))
+            return true;
+
+        return gameObject->DrawObject == null;
+    }
+
+    private static bool IsPointerValid(IntPtr ptr)
+    {
+        if (ptr == IntPtr.Zero)
+            return false;
+
         try
         {
-            var character = (Character*)playerPointer;
+            _ = Marshal.ReadByte(ptr);
-            if (character == null)
-                return true;
-
-            var gameObject = &character->GameObject;
-            if (gameObject == null)
-                return true;
-
-            return gameObject->DrawObject == null;
-        }
-        catch (AccessViolationException)
-        {
             return true;
         }
+        catch
+        {
+            return false;
+        }
     }
 
     private static bool IsCacheFresh(CacheEntry entry)
@@ -537,13 +556,31 @@ public class PlayerDataFactory
 
             var hash = g.Key;
 
+            var resolvedPath = g.Select(f => f.ResolvedPath).Distinct(StringComparer.OrdinalIgnoreCase);
+            var papPathSummary = string.Join(", ", resolvedPath);
+            if (papPathSummary.IsNullOrEmpty())
+                papPathSummary = "<unknown pap path>";
+
             Dictionary<string, List<ushort>>? papIndices = null;
 
             await _papParseLimiter.WaitAsync(ct).ConfigureAwait(false);
             try
             {
-                papIndices = await Task.Run(() => _modelAnalyzer.GetBoneIndicesFromPap(hash), ct)
+                try
-                    .ConfigureAwait(false);
+                {
+                    papIndices = await Task.Run(() => _modelAnalyzer.GetBoneIndicesFromPap(hash, persistToConfig: false), ct)
+                        .ConfigureAwait(false);
+                }
+                catch (SEHException ex)
+                {
+                    _logger.LogError(ex, "SEH exception while parsing PAP file (hash={hash}, path={path}). Error code: 0x{code:X}. Skipping this animation.", hash, papPathSummary, ex.ErrorCode);
+                    continue;
+                }
+                catch (Exception ex)
+                {
+                    _logger.LogError(ex, "Unexpected error parsing PAP file (hash={hash}, path={path}). Skipping this animation.", hash, papPathSummary);
+                    continue;
+                }
             }
             finally
             {
@@ -553,43 +590,75 @@ public class PlayerDataFactory
             if (papIndices == null || papIndices.Count == 0)
                 continue;
 
-            if (papIndices.All(k => k.Value.DefaultIfEmpty().Max() <= 105))
+            bool hasValidIndices = false;
+            try
+            {
+                hasValidIndices = papIndices.All(k => k.Value != null && k.Value.DefaultIfEmpty().Max() <= 105);
+            }
+            catch (Exception ex)
+            {
+                _logger.LogWarning(ex, "Error validating bone indices for PAP (hash={hash}, path={path}). Skipping.", hash, papPathSummary);
+                continue;
+            }
+
+            if (hasValidIndices)
                 continue;
 
             if (_logger.IsEnabled(LogLevel.Debug))
             {
-                var papBuckets = papIndices
+                try
-                    .Select(kvp => new
+                {
-                    {
+                    var papBuckets = papIndices
-                        Raw = kvp.Key,
+                        .Where(kvp => kvp.Value is { Count: > 0 })
-                        Key = XivDataAnalyzer.CanonicalizeSkeletonKey(kvp.Key),
+                        .Select(kvp => new
-                        Indices = kvp.Value
+                        {
-                    })
+                            Raw = kvp.Key,
-                    .Where(x => x.Indices is { Count: > 0 })
+                            Key = XivDataAnalyzer.CanonicalizeSkeletonKey(kvp.Key),
-                    .GroupBy(x => string.IsNullOrEmpty(x.Key) ? x.Raw : x.Key!, StringComparer.OrdinalIgnoreCase)
+                            Indices = kvp.Value
-                    .Select(grp =>
+                        })
-                    {
+                        .Where(x => x.Indices is { Count: > 0 })
-                        var all = grp.SelectMany(v => v.Indices).ToList();
+                        .GroupBy(x => string.IsNullOrEmpty(x.Key) ? x.Raw : x.Key!, StringComparer.OrdinalIgnoreCase)
-                        var min = all.Count > 0 ? all.Min() : 0;
+                        .Select(grp =>
-                        var max = all.Count > 0 ? all.Max() : 0;
+                        {
-                        var raws = string.Join(',', grp.Select(v => v.Raw).Distinct(StringComparer.OrdinalIgnoreCase));
+                            var all = grp.SelectMany(v => v.Indices).ToList();
-                        return $"{grp.Key}(min={min},max={max},raw=[{raws}])";
+                            var min = all.Count > 0 ? all.Min() : 0;
-                    })
+                            var max = all.Count > 0 ? all.Max() : 0;
-                    .ToList();
+                            var raws = string.Join(',', grp.Select(v => v.Raw).Distinct(StringComparer.OrdinalIgnoreCase));
+                            return $"{grp.Key}(min={min},max={max},raw=[{raws}])";
+                        })
+                        .ToList();
 
-                _logger.LogDebug("SEND pap buckets for hash={hash}: {b}",
+                    _logger.LogDebug("SEND pap buckets for hash={hash}: {b}",
-                    hash,
+                        hash,
-                    string.Join(" | ", papBuckets));
+                        string.Join(" | ", papBuckets));
+                }
+                catch (Exception ex)
+                {
+                    _logger.LogDebug(ex, "Error logging PAP bucket details for hash={hash}", hash);
+                }
             }
 
-            if (XivDataAnalyzer.IsPapCompatible(localBoneSets, papIndices, mode, allowBasedShift, allownNightIndex, out var reason))
+            bool isCompatible = false;
+            string reason = string.Empty;
+            try
+            {
+                isCompatible = XivDataAnalyzer.IsPapCompatible(localBoneSets, papIndices, mode, allowBasedShift, allownNightIndex, out reason);
+            }
+            catch (Exception ex)
+            {
+                _logger.LogWarning(ex, "Error checking PAP compatibility for hash={hash}, path={path}. Treating as incompatible.", hash, papPathSummary);
+                reason = $"Exception during compatibility check: {ex.Message}";
+                isCompatible = false;
+            }
+
+            if (isCompatible)
                 continue;
 
             noValidationFailed++;
 
             _logger.LogWarning(
-                "Animation PAP hash {hash} is not compatible with local skeletons; dropping all mappings for this hash. Reason: {reason}",
+                "Animation PAP is not compatible with local skeletons; dropping mappings for {papPath}. Reason: {reason}",
-                hash,
+                papPathSummary,
                 reason);
 
             var removedGamePaths = fragment.FileReplacements

LightlessSync/PlayerData/Handlers/GameObjectHandler.cs

@@ -78,7 +78,6 @@ public sealed class GameObjectHandler : DisposableMediatorSubscriberBase, IHighP
             if (msg.Address == Address)
             {
                 _haltProcessing = false;
-                Refresh();
             }
         });
 
@@ -114,16 +113,16 @@ public sealed class GameObjectHandler : DisposableMediatorSubscriberBase, IHighP
     public async Task ActOnFrameworkAfterEnsureNoDrawAsync(Action<Dalamud.Game.ClientState.Objects.Types.ICharacter> act, CancellationToken token)
     {
         while (await _dalamudUtil.RunOnFrameworkThread(() =>
-               {
+        {
-                   EnsureLatestObjectState();
+            EnsureLatestObjectState();
-                   if (CurrentDrawCondition != DrawCondition.None) return true;
+            if (CurrentDrawCondition != DrawCondition.None) return true;
-                   var gameObj = _dalamudUtil.CreateGameObject(Address);
+            var gameObj = _dalamudUtil.CreateGameObject(Address);
-                   if (gameObj is Dalamud.Game.ClientState.Objects.Types.ICharacter chara)
+            if (gameObj is Dalamud.Game.ClientState.Objects.Types.ICharacter chara)
-                   {
+            {
-                       act.Invoke(chara);
+                act.Invoke(chara);
-                   }
+            }
-                   return false;
+            return false;
-               }).ConfigureAwait(false))
+        }).ConfigureAwait(false))
         {
             await Task.Delay(250, token).ConfigureAwait(false);
         }
@@ -170,19 +169,13 @@ public sealed class GameObjectHandler : DisposableMediatorSubscriberBase, IHighP
         return $"{owned}/{ObjectKind}:{Name} ({Address:X},{DrawObjectAddress:X})";
     }
 
-    protected override void Dispose(bool disposing)
-    {
-        base.Dispose(disposing);
-
-        Mediator.Publish(new GameObjectHandlerDestroyedMessage(this, _isOwnedObject));
-    }
-
     private void CheckAndUpdateObject() => CheckAndUpdateObject(allowPublish: true);
 
-    private unsafe void CheckAndUpdateObject(bool allowPublish = true)
+    private unsafe void CheckAndUpdateObject(bool allowPublish)
     {
         var prevAddr = Address;
         var prevDrawObj = DrawObjectAddress;
+        string? nameString = null;
 
         Address = _getAddress();
 
@@ -193,10 +186,9 @@ public sealed class GameObjectHandler : DisposableMediatorSubscriberBase, IHighP
             EntityId = gameObject->EntityId;
 
             var chara = (Character*)Address;
-            var newName = chara->GameObject.NameString;
+            nameString = chara->GameObject.NameString;
-
+            if (!string.IsNullOrEmpty(nameString) && !string.Equals(nameString, Name, StringComparison.Ordinal))
-            if (!string.IsNullOrEmpty(newName) && !string.Equals(newName, Name, StringComparison.Ordinal))
+                Name = nameString;
-                Name = newName;
         }
         else
         {
@@ -214,16 +206,18 @@ public sealed class GameObjectHandler : DisposableMediatorSubscriberBase, IHighP
         if (Address != IntPtr.Zero && DrawObjectAddress != IntPtr.Zero)
         {
             var chara = (Character*)Address;
-            var name = chara->GameObject.NameString;
+            var drawObj = (DrawObject*)DrawObjectAddress;
-            bool nameChange = !string.Equals(name, Name, StringComparison.Ordinal);
+            var objType = drawObj->Object.GetObjectType();
-            if (nameChange)
+            var isHuman = objType == ObjectType.CharacterBase
-            {
+                          && ((CharacterBase*)drawObj)->GetModelType() == CharacterBase.ModelType.Human;
-                Name = name;
+
-            }
+            nameString ??= ((Character*)Address)->GameObject.NameString;
+            var nameChange = !string.Equals(nameString, Name, StringComparison.Ordinal);
+            if (nameChange) Name = nameString;
+
             bool equipDiff = false;
 
-            if (((DrawObject*)DrawObjectAddress)->Object.GetObjectType() == ObjectType.CharacterBase
+            if (isHuman)
-                && ((CharacterBase*)DrawObjectAddress)->GetModelType() == CharacterBase.ModelType.Human)
             {
                 var classJob = chara->CharacterData.ClassJob;
                 if (classJob != _classJob)
@@ -233,7 +227,7 @@ public sealed class GameObjectHandler : DisposableMediatorSubscriberBase, IHighP
                     Mediator.Publish(new ClassJobChangedMessage(this));
                 }
 
-                equipDiff = CompareAndUpdateEquipByteData((byte*)&((Human*)DrawObjectAddress)->Head);
+                equipDiff = CompareAndUpdateEquipByteData((byte*)&((Human*)drawObj)->Head);
 
                 ref var mh = ref chara->DrawData.Weapon(WeaponSlot.MainHand);
                 ref var oh = ref chara->DrawData.Weapon(WeaponSlot.OffHand);
@@ -258,12 +252,11 @@ public sealed class GameObjectHandler : DisposableMediatorSubscriberBase, IHighP
 
             bool customizeDiff = false;
 
-            if (((DrawObject*)DrawObjectAddress)->Object.GetObjectType() == ObjectType.CharacterBase
+            if (isHuman)
-                && ((CharacterBase*)DrawObjectAddress)->GetModelType() == CharacterBase.ModelType.Human)
             {
-                var gender = ((Human*)DrawObjectAddress)->Customize.Sex;
+                var gender = ((Human*)drawObj)->Customize.Sex;
-                var raceId = ((Human*)DrawObjectAddress)->Customize.Race;
+                var raceId = ((Human*)drawObj)->Customize.Race;
-                var tribeId = ((Human*)DrawObjectAddress)->Customize.Tribe;
+                var tribeId = ((Human*)drawObj)->Customize.Tribe;
 
                 if (_isOwnedObject && ObjectKind == ObjectKind.Player
                     && (gender != Gender || raceId != RaceId || tribeId != TribeId))
@@ -274,7 +267,7 @@ public sealed class GameObjectHandler : DisposableMediatorSubscriberBase, IHighP
                     TribeId = tribeId;
                 }
 
-                customizeDiff = CompareAndUpdateCustomizeData(((Human*)DrawObjectAddress)->Customize.Data);
+                customizeDiff = CompareAndUpdateCustomizeData(((Human*)drawObj)->Customize.Data);
                 if (customizeDiff)
                     Logger.LogTrace("Checking [{this}] customize data as human from draw obj, result: {diff}", this, customizeDiff);
             }

LightlessSync/Resources/LocalizationExtention.cs

@@ -0,0 +1,9 @@
+namespace LightlessSync.Resources;
+
+public static class LocalizationExtensions
+{
+    public static string F(this string mask, params object[] args)
+    {
+        return string.Format(mask, args);
+    }
+}

LightlessSync/Resources/Resources.Designer.cs

@@ -0,0 +1,170 @@
+//------------------------------------------------------------------------------
+// <auto-generated>
+//     This code was generated by a tool.
+//
+//     Changes to this file may cause incorrect behavior and will be lost if
+//     the code is regenerated.
+// </auto-generated>
+//------------------------------------------------------------------------------
+
+namespace LightlessSync.Resources {
+    using System;
+    
+    
+    /// <summary>
+    ///   A strongly-typed resource class, for looking up localized strings, etc.
+    /// </summary>
+    // This class was auto-generated by the StronglyTypedResourceBuilder
+    // class via a tool like ResGen or Visual Studio.
+    // To add or remove a member, edit your .ResX file then rerun ResGen
+    // with the /str option, or rebuild your VS project.
+    [global::System.CodeDom.Compiler.GeneratedCodeAttribute("System.Resources.Tools.StronglyTypedResourceBuilder", "4.0.0.0")]
+    [global::System.Diagnostics.DebuggerNonUserCodeAttribute()]
+    [global::System.Runtime.CompilerServices.CompilerGeneratedAttribute()]
+    public class Resources {
+        
+        private static global::System.Resources.ResourceManager resourceMan;
+        
+        private static global::System.Globalization.CultureInfo resourceCulture;
+        
+        [global::System.Diagnostics.CodeAnalysis.SuppressMessageAttribute("Microsoft.Performance", "CA1811:AvoidUncalledPrivateCode")]
+        internal Resources() {
+        }
+        
+        /// <summary>
+        ///   Returns the cached ResourceManager instance used by this class.
+        /// </summary>
+        [global::System.ComponentModel.EditorBrowsableAttribute(global::System.ComponentModel.EditorBrowsableState.Advanced)]
+        public static global::System.Resources.ResourceManager ResourceManager {
+            get {
+                if (object.ReferenceEquals(resourceMan, null)) {
+                    global::System.Resources.ResourceManager temp = new global::System.Resources.ResourceManager("LightlessSync.Resources.Resources", typeof(Resources).Assembly);
+                    resourceMan = temp;
+                }
+                return resourceMan;
+            }
+        }
+        
+        /// <summary>
+        ///   Overrides the current thread's CurrentUICulture property for all
+        ///   resource lookups using this strongly typed resource class.
+        /// </summary>
+        [global::System.ComponentModel.EditorBrowsableAttribute(global::System.ComponentModel.EditorBrowsableState.Advanced)]
+        public static global::System.Globalization.CultureInfo Culture {
+            get {
+                return resourceCulture;
+            }
+            set {
+                resourceCulture = value;
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to I agree.
+        /// </summary>
+        public static string ToSStrings_AgreeLabel {
+            get {
+                return ResourceManager.GetString("ToSStrings_AgreeLabel", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Agreement of Usage of Service.
+        /// </summary>
+        public static string ToSStrings_AgreementLabel {
+            get {
+                return ResourceManager.GetString("ToSStrings_AgreementLabel", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to &apos;I agree&apos; button will be available in.
+        /// </summary>
+        public static string ToSStrings_ButtonWillBeAvailableIn {
+            get {
+                return ResourceManager.GetString("ToSStrings_ButtonWillBeAvailableIn", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Language.
+        /// </summary>
+        public static string ToSStrings_LanguageLabel {
+            get {
+                return ResourceManager.GetString("ToSStrings_LanguageLabel", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to All of the mod files currently active on your character as well as your current character state will be uploaded to the service you registered yourself at automatically. The plugin will exclusively upload the necessary mod files and not the whole mod..
+        /// </summary>
+        public static string ToSStrings_Paragraph1 {
+            get {
+                return ResourceManager.GetString("ToSStrings_Paragraph1", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to If you are on a data capped internet connection, higher fees due to data usage depending on the amount of downloaded and uploaded mod files might occur. Mod files will be compressed on up- and download to save on bandwidth usage. Due to varying up- and download speeds, changes in characters might not be visible immediately. Files present on the service that already represent your active mod files will not be uploaded again..
+        /// </summary>
+        public static string ToSStrings_Paragraph2 {
+            get {
+                return ResourceManager.GetString("ToSStrings_Paragraph2", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to The mod files you are uploading are confidential and will not be distributed to parties other than the ones who are requesting the exact same mod files. Please think about who you are going to pair since it is unavoidable that they will receive and locally cache the necessary mod files that you have currently in use. Locally cached mod files will have arbitrary file names to discourage attempts at replicating the original mod..
+        /// </summary>
+        public static string ToSStrings_Paragraph3 {
+            get {
+                return ResourceManager.GetString("ToSStrings_Paragraph3", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to The plugin creator tried their best to keep you secure. However, there is no guarantee for 100% security. Do not blindly pair your client with everyone..
+        /// </summary>
+        public static string ToSStrings_Paragraph4 {
+            get {
+                return ResourceManager.GetString("ToSStrings_Paragraph4", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Mod files that are saved on the service will remain on the service as long as there are requests for the files from clients. After a period of not being used, the mod files will be automatically deleted. You will also be able to wipe all the files you have personally uploaded on request. The service holds no information about which mod files belong to which mod..
+        /// </summary>
+        public static string ToSStrings_Paragraph5 {
+            get {
+                return ResourceManager.GetString("ToSStrings_Paragraph5", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to This service is provided as-is. In case of abuse join the Lightless Sync Discord..
+        /// </summary>
+        public static string ToSStrings_Paragraph6 {
+            get {
+                return ResourceManager.GetString("ToSStrings_Paragraph6", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to READ THIS CAREFULLY.
+        /// </summary>
+        public static string ToSStrings_ReadLabel {
+            get {
+                return ResourceManager.GetString("ToSStrings_ReadLabel", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Users Online.
+        /// </summary>
+        public static string Users_Online {
+            get {
+                return ResourceManager.GetString("Users_Online", resourceCulture);
+            }
+        }
+    }
+}

LightlessSync/Resources/Resources.de.resx

@@ -0,0 +1,47 @@
+<root>
+    <resheader name="resmimetype">
+        <value>text/microsoft-resx</value>
+    </resheader>
+    <resheader name="version">
+        <value>1.3</value>
+    </resheader>
+    <resheader name="reader">
+        <value>System.Resources.ResXResourceReader, System.Windows.Forms, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+    </resheader>
+    <resheader name="writer">
+        <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+    </resheader>
+    <data name="ToSStrings_LanguageLabel" xml:space="preserve">
+        <value>Language</value>
+    </data>
+    <data name="ToSStrings_AgreementLabel" xml:space="preserve">
+        <value>Nutzungsbedingungen</value>
+    </data>
+    <data name="ToSStrings_ReadLabel" xml:space="preserve">
+        <value>BITTE LIES DIES SORGFÄLTIG</value>
+    </data>
+    <data name="ToSStrings_Paragraph1" xml:space="preserve">
+        <value>Alle Moddateien, die aktuell auf deinem Charakter aktiv sind und dein Charakterzustand werden automatisch zu dem Service, an dem du dich registriert hast, hochgeladen. Das Plugin wird ausschließlich die nötigen Moddateien hochladen und nicht die gesamte Modifikation.</value>
+    </data>
+    <data name="ToSStrings_Paragraph2" xml:space="preserve">
+        <value>Falls du mit einer getakteten Internetverbindung verbunden bist, können durch den Datentransfer von Hoch- und Runtergeladenen Moddateien höhere Kosten entstehen. Moddateien werden beim Hoch- und Runterladen komprimiert um Bandbreite zu sparen. Durch unterschiedliche Hoch- und Runterladgeschwindigkeiten ist es möglich, dass Änderungen an Charakteren nicht sofort sichtbar sind. Dateien die bereits auf dem Service existieren, werden nicht nochmals hochgeladen.</value>
+    </data>
+    <data name="ToSStrings_Paragraph3" xml:space="preserve">
+        <value>Die Moddateien die du hochlädst sind vertraulich und werden nicht mit anderen Nutzern geteilt, die nicht die exakt selben Dateien anfordern. Bitte überlege dir sorgfältig mit wem du deinen Identifikationscode teilst, da es unvermeidlich ist, dass die andere Person deine Moddateien erhält und lokal zwischenspeichert. Lokal zwischengespeicherte Dateien haben willkürrliche Namen um vor Versuchen abzuschrecken die originalen Moddateien aus diesen wiederherzustellen.</value>
+    </data>
+    <data name="ToSStrings_Paragraph4" xml:space="preserve">
+        <value>Der Ersteller des Plugins hat sein Bestes getan, um deine Sicherheit zu gewährleisten. Es gibt jedoch keine Garantie für 100%ige Sicherheit. Teile deinen Identifikationscode nicht blind mit jedem.</value>
+    </data>
+    <data name="ToSStrings_Paragraph5" xml:space="preserve">
+        <value>Moddateien, die auf dem Service gespeichert sind, verbleiben auf dem Service, solange es Anforderungen für diese Dateien gibt. Nach einer Zeitspanne in der die Dateien nicht verwendet wurden, werden diese automatisch gelöscht. Du hast auch die Möglichkeit manuell alle Dateien auf dem Service zu löschen. Der Service hat keine Informationen welche Moddateien zu welcher Modifikation gehören.</value>
+    </data>
+    <data name="ToSStrings_Paragraph6" xml:space="preserve">
+        <value>Dieser Dienst wird ohne Gewähr angeboten. Im Falle eines Missbrauchs tretet dem Lightless Sync Discord bei.</value>
+    </data>
+    <data name="ToSStrings_AgreeLabel" xml:space="preserve">
+        <value>Ich Stimme zu</value>
+    </data>
+    <data name="ToSStrings_ButtonWillBeAvailableIn" xml:space="preserve">
+        <value>"Ich stimme zu" Knopf verfügbar in</value>
+    </data>
+</root>

LightlessSync/Resources/Resources.fr.resx

@@ -0,0 +1,47 @@
+<root>
+    <resheader name="resmimetype">
+        <value>text/microsoft-resx</value>
+    </resheader>
+    <resheader name="version">
+        <value>1.3</value>
+    </resheader>
+    <resheader name="reader">
+        <value>System.Resources.ResXResourceReader, System.Windows.Forms, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+    </resheader>
+    <resheader name="writer">
+        <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+    </resheader>
+    <data name="ToSStrings_LanguageLabel" xml:space="preserve">
+        <value>Language</value>
+    </data>
+    <data name="ToSStrings_AgreementLabel" xml:space="preserve">
+        <value>Conditions d'Utilisation</value>
+    </data>
+    <data name="ToSStrings_ReadLabel" xml:space="preserve">
+        <value>LISEZ CES INFORMATIONS ATTENTIVEMENT</value>
+    </data>
+    <data name="ToSStrings_Paragraph1" xml:space="preserve">
+        <value>Tous les fichiers moddés actuellement en cours d'utilisation ainsi que le statut actuel de votre personnage vont être mix en ligne via le service sur lequel vous vous êtes automatiquement enregistré. Seuls les fichiers nécessaires seront téléversés par le plugin et non pas le mod en entier.</value>
+    </data>
+    <data name="ToSStrings_Paragraph2" xml:space="preserve">
+        <value>Si le débit de votre connexion internet est limité, le téléchargement et téléversement d'un grand nombre de fichiers peut entraîner des coûts supplémentaires. Les fichiers seront compressés au chargement et versement pour réduire l'impact sur votre bande passants. Selon la rapidité de vos téléchargements et téléversements, les changements ne seront peut-être pas visibles instantanément sur les personnages. Les fichiers déja présents sur le service qui correspondent à ceux de vos mods en cours d'utilisation ne seront pas remis en ligne.</value>
+    </data>
+    <data name="ToSStrings_Paragraph3" xml:space="preserve">
+        <value>Les fichiers que vous allez partager sont confidentiels et ne seront envoyés qu'aux utilisateurs qui feront une requête exacte de ceux-çi. Nous vous demandons de (re)considérer qui sera synchronisé avec vous, puisqu'ils recevront et stockeront inévitablement en local les fichiers nécéssaires utilisés à cet instant. Les noms des fichiers stockés localement sont changés de manière arbitraire afin de décourager toute tentative de réplication des originaux.</value>
+    </data>
+    <data name="ToSStrings_Paragraph4" xml:space="preserve">
+        <value>Le créateur de ce plugin a tenté de sécuriser l'application du mieux possible. Cependant, il ne peut pas garantir une protection 100% infaillible. Pour votre sécurité, ne vous synchronisez pas aveuglément et avec n'importe qui.</value>
+    </data>
+    <data name="ToSStrings_Paragraph5" xml:space="preserve">
+        <value>Les fichiers sauvegardés sur le service resteront en ligne tant que des utilisateurs en feront usage. Ils seront effacés automatiquement après une certaine période d'inactivité. Vous pouvez également demander l'effacement de tous les fichiers que vous avez mis en ligne vous-même. Le service en soi ne contient aucune information pouvant identifier quel fichier appartient à quel mod.</value>
+    </data>
+    <data name="ToSStrings_Paragraph6" xml:space="preserve">
+        <value>Ce service et ses composants vous sont fournis en l'état. En cas d'abus rejoindre le serveur Discord Lightless Sync.</value>
+    </data>
+    <data name="ToSStrings_AgreeLabel" xml:space="preserve">
+        <value>J'accept</value>
+    </data>
+    <data name="ToSStrings_ButtonWillBeAvailableIn" xml:space="preserve">
+        <value>Bouton "J'accept" disposible dans</value>
+    </data>
+</root>

LightlessSync/Resources/Resources.resx

@@ -0,0 +1,57 @@
+<?xml version="1.0" encoding="utf-8"?>
+
+<root>
+    <xsd:schema id="root" xmlns="" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">
+        <xsd:element name="root" msdata:IsDataSet="true">
+            
+        </xsd:element>
+    </xsd:schema>
+    <resheader name="resmimetype">
+        <value>text/microsoft-resx</value>
+    </resheader>
+    <resheader name="version">
+        <value>1.3</value>
+    </resheader>
+    <resheader name="reader">
+        <value>System.Resources.ResXResourceReader, System.Windows.Forms, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+    </resheader>
+    <resheader name="writer">
+        <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+    </resheader>
+    <data name="ToSStrings_AgreeLabel" xml:space="preserve">
+        <value>I agree</value>
+    </data>
+    <data name="ToSStrings_AgreementLabel" xml:space="preserve">
+        <value>Agreement of Usage of Service</value>
+    </data>
+    <data name="ToSStrings_ButtonWillBeAvailableIn" xml:space="preserve">
+        <value>'I agree' button will be available in</value>
+    </data>
+    <data name="ToSStrings_Paragraph1" xml:space="preserve">
+        <value>All of the mod files currently active on your character as well as your current character state will be uploaded to the service you registered yourself at automatically. The plugin will exclusively upload the necessary mod files and not the whole mod.</value>
+    </data>
+    <data name="ToSStrings_Paragraph2" xml:space="preserve">
+        <value>If you are on a data capped internet connection, higher fees due to data usage depending on the amount of downloaded and uploaded mod files might occur. Mod files will be compressed on up- and download to save on bandwidth usage. Due to varying up- and download speeds, changes in characters might not be visible immediately. Files present on the service that already represent your active mod files will not be uploaded again.</value>
+    </data>
+    <data name="ToSStrings_Paragraph3" xml:space="preserve">
+        <value>The mod files you are uploading are confidential and will not be distributed to parties other than the ones who are requesting the exact same mod files. Please think about who you are going to pair since it is unavoidable that they will receive and locally cache the necessary mod files that you have currently in use. Locally cached mod files will have arbitrary file names to discourage attempts at replicating the original mod.</value>
+    </data>
+    <data name="ToSStrings_Paragraph4" xml:space="preserve">
+        <value>The plugin creator tried their best to keep you secure. However, there is no guarantee for 100% security. Do not blindly pair your client with everyone.</value>
+    </data>
+    <data name="ToSStrings_Paragraph5" xml:space="preserve">
+        <value>Mod files that are saved on the service will remain on the service as long as there are requests for the files from clients. After a period of not being used, the mod files will be automatically deleted. You will also be able to wipe all the files you have personally uploaded on request. The service holds no information about which mod files belong to which mod.</value>
+    </data>
+    <data name="ToSStrings_Paragraph6" xml:space="preserve">
+        <value>This service is provided as-is. In case of abuse join the Lightless Sync Discord.</value>
+    </data>
+    <data name="ToSStrings_ReadLabel" xml:space="preserve">
+        <value>READ THIS CAREFULLY</value>
+    </data>
+    <data name="ToSStrings_LanguageLabel" xml:space="preserve">
+        <value>Language</value>
+    </data>
+    <data name="Users_Online" xml:space="preserve">
+        <value>Users Online</value>
+    </data>
+</root>

LightlessSync/Resources/Resources.zh.resx

@@ -0,0 +1,20 @@
+<root>
+    <resheader name="resmimetype">
+        <value>text/microsoft-resx</value>
+    </resheader>
+    <resheader name="version">
+        <value>1.3</value>
+    </resheader>
+    <resheader name="reader">
+        <value>System.Resources.ResXResourceReader, System.Windows.Forms, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+    </resheader>
+    <resheader name="writer">
+        <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+    </resheader>
+    <data name="ToSStrings_LanguageLabel" xml:space="preserve">
+        <value>语言</value>
+    </data>
+    <data name="Users_Online" xml:space="preserve">
+        <value>用户在线</value>
+    </data>
+</root>

LightlessSync/Services/DalamudUtilService.cs

@@ -93,7 +93,7 @@ public class DalamudUtilService : IHostedService, IMediatorSubscriber
         {
             return gameData.GetExcelSheet<Lumina.Excel.Sheets.World>(clientLanguage)!
                 .Where(w => !w.Name.IsEmpty && w.DataCenter.RowId != 0 && (w.IsPublic || char.IsUpper(w.Name.ToString()[0])
-                    || w is { RowId: > 1000, Region: 101 or 201 }))
+                    || w is { RowId: > 1000, UserType: 101 or 201 }))
                 .ToDictionary(w => (ushort)w.RowId, w => w.Name.ToString());
         });
         JobData = new(() =>
@@ -666,7 +666,7 @@ public class DalamudUtilService : IHostedService, IMediatorSubscriber
 
         var location = new LocationInfo();
         location.ServerId = _playerState.CurrentWorld.RowId;
-        location.InstanceId = UIState.Instance()->PublicInstance.InstanceId; 
+        location.InstanceId = UIState.Instance()->PublicInstance.InstanceId;
         location.TerritoryId = _clientState.TerritoryType;
         location.MapId = _clientState.MapId;
         if (houseMan != null)
@@ -699,13 +699,13 @@ public class DalamudUtilService : IHostedService, IMediatorSubscriber
         }
         return location;
     }
-    
+
     public string LocationToString(LocationInfo location)
     {
         if (location.ServerId is 0 || location.TerritoryId is 0) return String.Empty;
         var str = WorldData.Value[(ushort)location.ServerId];
 
-        if (ContentFinderData.Value.TryGetValue(location.TerritoryId , out var dutyName))
+        if (ContentFinderData.Value.TryGetValue(location.TerritoryId, out var dutyName))
         {
             str += $" - [In Duty]{dutyName}";
         }
@@ -856,7 +856,7 @@ public class DalamudUtilService : IHostedService, IMediatorSubscriber
 
         var token = ct ?? CancellationToken.None;
 
-        const int tick = 250; 
+        const int tick = 250;
         const int initialSettle = 50;
 
         var sw = Stopwatch.StartNew();
@@ -881,7 +881,7 @@ public class DalamudUtilService : IHostedService, IMediatorSubscriber
         {
             // ignore
         }
-        catch (AccessViolationException ex)
+        catch (Exception ex)
         {
             logger.LogWarning(ex, "Error accessing {handler}, object does not exist anymore?", handler);
         }
@@ -922,11 +922,11 @@ public class DalamudUtilService : IHostedService, IMediatorSubscriber
     public string? GetWorldNameFromPlayerAddress(nint address)
     {
         if (address == nint.Zero) return null;
-        
+
         EnsureIsOnFramework();
         var playerCharacter = _objectTable.OfType<IPlayerCharacter>().FirstOrDefault(p => p.Address == address);
         if (playerCharacter == null) return null;
-        
+
         var worldId = (ushort)playerCharacter.HomeWorld.RowId;
         return WorldData.Value.TryGetValue(worldId, out var worldName) ? worldName : null;
     }
@@ -953,105 +953,108 @@ public class DalamudUtilService : IHostedService, IMediatorSubscriber
         });
     }
 
+    [DllImport("kernel32.dll", SetLastError = true)]
+    private static extern bool IsBadReadPtr(IntPtr ptr, UIntPtr size);
+
+    private static bool IsValidPointer(nint ptr, int size = 8)
+    {
+        if (ptr == nint.Zero)
+            return false;
+
+        try
+        {
+            if (!Util.IsWine())
+            {
+                return !IsBadReadPtr(ptr, (UIntPtr)size);
+            }
+            return ptr != nint.Zero && (ptr % IntPtr.Size) == 0;
+        }
+        catch
+        {
+            return false;
+        }
+    }
+
     private unsafe void CheckCharacterForDrawing(nint address, string characterName)
     {
         if (address == nint.Zero)
             return;
 
-        try
+        if (!IsValidPointer(address))
         {
-            var gameObj = (GameObject*)address;
+            _logger.LogDebug("Invalid pointer for character {name} at {addr}", characterName, address.ToString("X"));
+            return;
+        }
 
-            if (gameObj == null)
+        var gameObj = (GameObject*)address;
-                return;
 
-            if (!_objectTable.Any(o => o?.Address == address))
+        if (gameObj == null)
+            return;
+
+        if (!_objectTable.Any(o => o?.Address == address))
+        {
+            _logger.LogDebug("Character {name} at {addr} no longer in object table", characterName, address.ToString("X"));
+            return;
+        }
+
+        if (gameObj->ObjectKind == 0)
+            return;
+
+        var drawObj = gameObj->DrawObject;
+        bool isDrawing = false;
+        bool isDrawingChanged = false;
+
+        if ((nint)drawObj != IntPtr.Zero && IsValidPointer((nint)drawObj))
+        {
+            isDrawing = gameObj->RenderFlags == (VisibilityFlags)0b100000000000;
+
+            if (!isDrawing)
             {
-                _logger.LogDebug("Character {name} at {addr} no longer in object table", characterName, address.ToString("X"));
+                var charBase = (CharacterBase*)drawObj;
-                return;
+                if (charBase != null && IsValidPointer((nint)charBase))
-            }
-
-            if (gameObj->ObjectKind == 0)
-                return;
-
-            var drawObj = gameObj->DrawObject;
-            bool isDrawing = false;
-            bool isDrawingChanged = false;
-
-            if ((nint)drawObj != IntPtr.Zero)
-            {
-                try
                 {
-                    isDrawing = gameObj->RenderFlags == (VisibilityFlags)0b100000000000;
+                    isDrawing = charBase->HasModelInSlotLoaded != 0;
-                }
+                    if (!isDrawing)
-                catch (AccessViolationException)
-                {
-                    return;
-                }
-
-                if (!isDrawing)
-                {
-                    try
                     {
-                        var charBase = (CharacterBase*)drawObj;
+                        isDrawing = charBase->HasModelFilesInSlotLoaded != 0;
-                        if (charBase != null)
+                        if (isDrawing && !string.Equals(_lastGlobalBlockPlayer, characterName, StringComparison.Ordinal)
+                            && !string.Equals(_lastGlobalBlockReason, "HasModelFilesInSlotLoaded", StringComparison.Ordinal))
                         {
-                            isDrawing = charBase->HasModelInSlotLoaded != 0;
+                            _lastGlobalBlockPlayer = characterName;
-                            if (!isDrawing)
+                            _lastGlobalBlockReason = "HasModelFilesInSlotLoaded";
-                            {
+                            isDrawingChanged = true;
-                                isDrawing = charBase->HasModelFilesInSlotLoaded != 0;
-                                if (isDrawing && !string.Equals(_lastGlobalBlockPlayer, characterName, StringComparison.Ordinal)
-                                    && !string.Equals(_lastGlobalBlockReason, "HasModelFilesInSlotLoaded", StringComparison.Ordinal))
-                                {
-                                    _lastGlobalBlockPlayer = characterName;
-                                    _lastGlobalBlockReason = "HasModelFilesInSlotLoaded";
-                                    isDrawingChanged = true;
-                                }
-                            }
-                            else
-                            {
-                                if (!string.Equals(_lastGlobalBlockPlayer, characterName, StringComparison.Ordinal)
-                                    && !string.Equals(_lastGlobalBlockReason, "HasModelInSlotLoaded", StringComparison.Ordinal))
-                                {
-                                    _lastGlobalBlockPlayer = characterName;
-                                    _lastGlobalBlockReason = "HasModelInSlotLoaded";
-                                    isDrawingChanged = true;
-                                }
-                            }
                         }
                     }
-                    catch (AccessViolationException)
+                    else
                     {
-                        return;
+                        if (!string.Equals(_lastGlobalBlockPlayer, characterName, StringComparison.Ordinal)
-                    }
+                            && !string.Equals(_lastGlobalBlockReason, "HasModelInSlotLoaded", StringComparison.Ordinal))
-                }
+                        {
-                else
+                            _lastGlobalBlockPlayer = characterName;
-                {
+                            _lastGlobalBlockReason = "HasModelInSlotLoaded";
-                    if (!string.Equals(_lastGlobalBlockPlayer, characterName, StringComparison.Ordinal)
+                            isDrawingChanged = true;
-                        && !string.Equals(_lastGlobalBlockReason, "RenderFlags", StringComparison.Ordinal))
+                        }
-                    {
-                        _lastGlobalBlockPlayer = characterName;
-                        _lastGlobalBlockReason = "RenderFlags";
-                        isDrawingChanged = true;
                     }
                 }
             }
-
+            else
-            if (isDrawingChanged)
             {
-                _logger.LogTrace("Global draw block: START => {name} ({reason})", characterName, _lastGlobalBlockReason);
+                if (!string.Equals(_lastGlobalBlockPlayer, characterName, StringComparison.Ordinal)
+                    && !string.Equals(_lastGlobalBlockReason, "RenderFlags", StringComparison.Ordinal))
+                {
+                    _lastGlobalBlockPlayer = characterName;
+                    _lastGlobalBlockReason = "RenderFlags";
+                    isDrawingChanged = true;
+                }
             }
+        }
 
-            IsAnythingDrawing |= isDrawing;
+        if (isDrawingChanged)
-        }
-        catch (AccessViolationException ex)
         {
-            _logger.LogDebug(ex, "Memory access violation checking character {name} at {addr}", characterName, address.ToString("X"));
+            _logger.LogTrace("Global draw block: START => {name} ({reason})", characterName, _lastGlobalBlockReason);
-        }
-        catch (Exception ex)
-        {
-            _logger.LogWarning(ex, "Unexpected error checking character {name} at {addr}", characterName, address.ToString("X"));
         }
+
+        IsAnythingDrawing |= isDrawing;
     }
 
     private void FrameworkOnUpdate(IFramework framework)
@@ -1061,6 +1064,11 @@ public class DalamudUtilService : IHostedService, IMediatorSubscriber
 
     private unsafe void FrameworkOnUpdateInternal()
     {
+        if (!_clientState.IsLoggedIn || _objectTable.LocalPlayer == null)
+        {
+            return;
+        }
+
         if ((_objectTable.LocalPlayer?.IsDead ?? false) && _condition[ConditionFlag.BoundByDuty])
         {
             return;
@@ -1084,70 +1092,38 @@ public class DalamudUtilService : IHostedService, IMediatorSubscriber
 
                     for (var i = 0; i < descriptorCount; i++)
                     {
-                        try
+                        if (i >= playerDescriptors.Count)
+                            break;
+
+                        var actor = playerDescriptors[i];
+
+                        var playerAddress = actor.Address;
+                        if (playerAddress == nint.Zero || !IsValidPointer(playerAddress))
+                            continue;
+
+                        if (actor.ObjectIndex >= 200)
+                            continue;
+
+                        if (_blockedCharacterHandler.IsCharacterBlocked(playerAddress, actor.ObjectIndex, out bool firstTime) && firstTime)
                         {
-                            if (i >= playerDescriptors.Count)
+                            _logger.LogTrace("Skipping character {addr}, blocked/muted", playerAddress.ToString("X"));
+                            continue;
+                        }
+
+                        if (!IsAnythingDrawing)
+                        {
+                            if (!_objectTable.Any(o => o?.Address == playerAddress))
+                            {
+                                continue;
+                            }
+
+                            CheckCharacterForDrawing(playerAddress, actor.Name);
+
+                            if (IsAnythingDrawing)
                                 break;
-
-                            var actor = playerDescriptors[i];
-
-                            var playerAddress = actor.Address;
-                            if (playerAddress == nint.Zero)
-                                continue;
-
-                            if (actor.ObjectIndex >= 200)
-                                continue;
-
-                            if (_blockedCharacterHandler.IsCharacterBlocked(playerAddress, actor.ObjectIndex, out bool firstTime) && firstTime)
-                            {
-                                _logger.LogTrace("Skipping character {addr}, blocked/muted", playerAddress.ToString("X"));
-                                continue;
-                            }
-
-                            if (!IsAnythingDrawing)
-                            {
-                                try
-                                {
-                                    var gameObj = (GameObject*)playerAddress;
-
-                                    if (gameObj == null || gameObj->ObjectKind == 0)
-                                    {
-                                        continue;
-                                    }
-
-                                    string currentName;
-                                    try
-                                    {
-                                        currentName = gameObj->NameString ?? string.Empty;
-                                    }
-                                    catch (AccessViolationException)
-                                    {
-                                        currentName = string.Empty;
-                                    }
-
-                                    var charaName = string.IsNullOrEmpty(currentName) ? actor.Name : currentName;
-
-                                    CheckCharacterForDrawing(playerAddress, charaName);
-
-                                    if (IsAnythingDrawing)
-                                        break;
-                                }
-                                catch (AccessViolationException ex)
-                                {
-                                    _logger.LogDebug(ex, "Access violation on GameObject pointer for actor {index} at {addr}", i, playerAddress.ToString("X"));
-                                }
-                            }
-                        }
-                        catch (AccessViolationException ex)
-                        {
-                            _logger.LogDebug(ex, "Access violation processing actor {index} - object likely destroyed", i);
-                        }
-                        catch (Exception ex)
-                        {
-                            _logger.LogWarning(ex, "Unexpected error processing actor {index}", i);
                         }
                     }
-             });
+                });
 
             if (!IsAnythingDrawing && !string.IsNullOrEmpty(_lastGlobalBlockPlayer))
             {
@@ -1214,7 +1190,7 @@ public class DalamudUtilService : IHostedService, IMediatorSubscriber
                 });
 
             // Cutscene
-            HandleStateTransition(() => IsInCutscene,v => IsInCutscene = v, shouldBeInCutscene, "Cutscene",
+            HandleStateTransition(() => IsInCutscene, v => IsInCutscene = v, shouldBeInCutscene, "Cutscene",
                 onEnter: () =>
                 {
                     Mediator.Publish(new CutsceneStartMessage());
@@ -1257,7 +1233,7 @@ public class DalamudUtilService : IHostedService, IMediatorSubscriber
                 Mediator.Publish(new ZoneSwitchEndMessage());
                 Mediator.Publish(new ResumeScanMessage(nameof(ConditionFlag.BetweenAreas)));
             }
-            
+
             //Map
             if (!_sentBetweenAreas)
             {
@@ -1268,7 +1244,7 @@ public class DalamudUtilService : IHostedService, IMediatorSubscriber
                     Mediator.Publish(new MapChangedMessage(mapid));
                 }
             }
-            
+
 
             var localPlayer = _objectTable.LocalPlayer;
             if (localPlayer != null)
@@ -1354,4 +1330,4 @@ public class DalamudUtilService : IHostedService, IMediatorSubscriber
             onExit();
         }
     }
-}
+}

LightlessSync/Services/XivDataAnalyzer.cs

@@ -1,5 +1,6 @@
 using FFXIVClientStructs.FFXIV.Client.Game.Character;
 using FFXIVClientStructs.FFXIV.Client.Graphics.Scene;
+using FFXIVClientStructs.Havok.Common.Serialize.Resource;
 using FFXIVClientStructs.Havok.Animation;
 using FFXIVClientStructs.Havok.Common.Base.Types;
 using FFXIVClientStructs.Havok.Common.Serialize.Util;
@@ -145,156 +146,297 @@ public sealed partial class XivDataAnalyzer
         using var reader = new BinaryReader(fs);
 
         // PAP header (mostly from vfxeditor)
-        _ = reader.ReadInt32(); // ignore
-        _ = reader.ReadInt32(); // ignore
-        _ = reader.ReadInt16(); // num animations
-        _ = reader.ReadInt16(); // modelid
-
-        var type = reader.ReadByte(); // type
-        if (type != 0)
-            return null; // not human
-
-        _ = reader.ReadByte();  // variant
-        _ = reader.ReadInt32(); // ignore
-
-        var havokPosition = reader.ReadInt32();
-        var footerPosition = reader.ReadInt32();
-
-        // sanity checks
-        if (havokPosition <= 0 || footerPosition <= havokPosition || footerPosition > fs.Length)
-            return null;
-
-        var havokDataSizeLong = (long)footerPosition - havokPosition;
-        if (havokDataSizeLong <= 8 || havokDataSizeLong > int.MaxValue)
-            return null;
-
-        var havokDataSize = (int)havokDataSizeLong;
-
-        reader.BaseStream.Position = havokPosition;
-        var havokData = reader.ReadBytes(havokDataSize);
-        if (havokData.Length <= 8)
-            return null;
-
-        var tempSets = new Dictionary<string, HashSet<ushort>>(StringComparer.OrdinalIgnoreCase);
-
-        var tempHavokDataPath = Path.Combine(Path.GetTempPath(), $"lightless_{Guid.NewGuid():N}.hkx");
-        IntPtr tempHavokDataPathAnsi = IntPtr.Zero;
-
         try
         {
-            File.WriteAllBytes(tempHavokDataPath, havokData);
+            _ = reader.ReadInt32(); // ignore
+            _ = reader.ReadInt32(); // ignore
+            var numAnimations = reader.ReadInt16(); // num animations
+            var modelId = reader.ReadInt16(); // modelid
 
-            if (!File.Exists(tempHavokDataPath))
+            if (numAnimations < 0 || numAnimations > 1000)
             {
-                _logger.LogTrace("Temporary havok file did not exist when attempting to load: {path}", tempHavokDataPath);
+                _logger.LogWarning("PAP file {hash} has invalid animation count {count}, skipping", hash, numAnimations);
                 return null;
             }
 
-            tempHavokDataPathAnsi = Marshal.StringToHGlobalAnsi(tempHavokDataPath);
+            var type = reader.ReadByte(); // type
+            if (type != 0)
+                return null; // not human
 
-            var loadoptions = stackalloc hkSerializeUtil.LoadOptions[1];
+            _ = reader.ReadByte();  // variant
-            loadoptions->TypeInfoRegistry = hkBuiltinTypeRegistry.Instance()->GetTypeInfoRegistry();
+            _ = reader.ReadInt32(); // ignore
-            loadoptions->ClassNameRegistry = hkBuiltinTypeRegistry.Instance()->GetClassNameRegistry();
-            loadoptions->Flags = new hkFlags<hkSerializeUtil.LoadOptionBits, int>
-            {
-                Storage = (int)hkSerializeUtil.LoadOptionBits.Default
-            };
 
-            var resource = hkSerializeUtil.LoadFromFile((byte*)tempHavokDataPathAnsi, null, loadoptions);
+            var havokPosition = reader.ReadInt32();
-            if (resource == null)
+            var footerPosition = reader.ReadInt32();
+
+            if (havokPosition <= 0 || footerPosition <= havokPosition ||
+                footerPosition > fs.Length || havokPosition >= fs.Length)
             {
-                _logger.LogWarning("Havok resource was null after loading from {path}", tempHavokDataPath);
+                _logger.LogWarning("PAP file {hash} has invalid offsets (havok={havok}, footer={footer}, length={length})",
+                    hash, havokPosition, footerPosition, fs.Length);
                 return null;
             }
 
-            var rootLevelName = @"hkRootLevelContainer"u8;
+            var havokDataSizeLong = (long)footerPosition - havokPosition;
-            fixed (byte* n1 = rootLevelName)
+            if (havokDataSizeLong <= 8 || havokDataSizeLong > int.MaxValue) 
             {
-                var container = (hkRootLevelContainer*)resource->GetContentsPointer(n1, hkBuiltinTypeRegistry.Instance()->GetTypeInfoRegistry());
+                _logger.LogWarning("PAP file {hash} has invalid Havok data size {size}", hash, havokDataSizeLong);
-                if (container == null)
+                return null;
-                    return null;
+            }
 
-                var animationName = @"hkaAnimationContainer"u8;
+            var havokDataSize = (int)havokDataSizeLong;
-                fixed (byte* n2 = animationName)
+
+            reader.BaseStream.Position = havokPosition;
+
+            var havokData = new byte[havokDataSize];
+            var bytesRead = reader.Read(havokData, 0, havokDataSize);
+            if (bytesRead != havokDataSize)
+            {
+                _logger.LogWarning("PAP file {hash}: Expected to read {expected} bytes but got {actual}",
+                    hash, havokDataSize, bytesRead);
+                return null;
+            }
+
+            if (havokData.Length < 8)
+                return null;
+
+            var tempSets = new Dictionary<string, HashSet<ushort>>(StringComparer.OrdinalIgnoreCase);
+
+            var tempFileName = $"lightless_pap_{Guid.NewGuid():N}_{hash.Substring(0, Math.Min(8, hash.Length))}.hkx";
+            var tempHavokDataPath = Path.Combine(Path.GetTempPath(), tempFileName);
+            IntPtr tempHavokDataPathAnsi = IntPtr.Zero;
+
+            try
+            {
+                var tempDir = Path.GetDirectoryName(tempHavokDataPath);
+                if (!Directory.Exists(tempDir))
                 {
-                    var animContainer = (hkaAnimationContainer*)container->findObjectByName(n2, null);
+                    _logger.LogWarning("Temp directory {dir} doesn't exist", tempDir);
-                    if (animContainer == null)
+                    return null;
-                        return null;
+                }
 
-                    for (int i = 0; i < animContainer->Bindings.Length; i++)
+                File.WriteAllBytes(tempHavokDataPath, havokData);
+
+                if (!File.Exists(tempHavokDataPath))
+                {
+                    _logger.LogWarning("Temporary havok file was not created at {path}", tempHavokDataPath);
+                    return null;
+                }
+
+                var writtenFileInfo = new FileInfo(tempHavokDataPath);
+                if (writtenFileInfo.Length != havokData.Length)
+                {
+                    _logger.LogWarning("Written temp file size mismatch: expected {expected}, got {actual}",
+                        havokData.Length, writtenFileInfo.Length);
+                    File.Delete(tempHavokDataPath);
+                    return null;
+                }
+
+                tempHavokDataPathAnsi = Marshal.StringToHGlobalAnsi(tempHavokDataPath);
+
+                var loadoptions = stackalloc hkSerializeUtil.LoadOptions[1];
+                loadoptions->TypeInfoRegistry = hkBuiltinTypeRegistry.Instance()->GetTypeInfoRegistry();
+                loadoptions->ClassNameRegistry = hkBuiltinTypeRegistry.Instance()->GetClassNameRegistry();
+                loadoptions->Flags = new hkFlags<hkSerializeUtil.LoadOptionBits, int>
+                {
+                    Storage = (int)hkSerializeUtil.LoadOptionBits.Default
+                };
+
+                hkResource* resource = null;
+                try
+                {
+                    resource = hkSerializeUtil.LoadFromFile((byte*)tempHavokDataPathAnsi, null, loadoptions);
+                }
+                catch (SEHException ex)
+                {
+                    _logger.LogError(ex, "SEH exception loading Havok file from {path} (hash={hash}). Native error code: 0x{code:X}",
+                        tempHavokDataPath, hash, ex.ErrorCode);
+                    return null;
+                }
+
+                if (resource == null)
+                {
+                    _logger.LogDebug("Havok resource was null after loading from {path} (hash={hash})", tempHavokDataPath, hash);
+                    return null;
+                }
+
+                if ((nint)resource == nint.Zero || !IsValidPointer((IntPtr)resource))
+                {
+                    _logger.LogDebug("Havok resource pointer is invalid (hash={hash})", hash);
+                    return null;
+                }
+
+                var rootLevelName = @"hkRootLevelContainer"u8;
+                fixed (byte* n1 = rootLevelName)
+                {
+                    var container = (hkRootLevelContainer*)resource->GetContentsPointer(n1, hkBuiltinTypeRegistry.Instance()->GetTypeInfoRegistry());
+                    if (container == null)
                     {
-                        var binding = animContainer->Bindings[i].ptr;
+                        _logger.LogDebug("hkRootLevelContainer is null (hash={hash})", hash);
-                        if (binding == null)
+                        return null;
-                            continue;
+                    }
 
-                        var rawSkel = binding->OriginalSkeletonName.String;
+                    if ((nint)container == nint.Zero || !IsValidPointer((IntPtr)container))
-                        var skeletonKey = CanonicalizeSkeletonKey(rawSkel);
+                    {
-                        if (string.IsNullOrEmpty(skeletonKey))
+                        _logger.LogDebug("hkRootLevelContainer pointer is invalid (hash={hash})", hash);
-                            continue;
+                        return null;
+                    }
 
-                        var boneTransform = binding->TransformTrackToBoneIndices;
+                    var animationName = @"hkaAnimationContainer"u8;
-                        if (boneTransform.Length <= 0)
+                    fixed (byte* n2 = animationName)
-                            continue;
+                    {
-
+                        var animContainer = (hkaAnimationContainer*)container->findObjectByName(n2, null);
-                        if (!tempSets.TryGetValue(skeletonKey, out var set))
+                        if (animContainer == null)
                         {
-                            set = [];
+                            _logger.LogDebug("hkaAnimationContainer is null (hash={hash})", hash);
-                            tempSets[skeletonKey] = set;
+                            return null;
                         }
 
-                        for (int boneIdx = 0; boneIdx < boneTransform.Length; boneIdx++)
+                        if ((nint)animContainer == nint.Zero || !IsValidPointer((IntPtr)animContainer))
                         {
-                            var v = boneTransform[boneIdx];
+                            _logger.LogDebug("hkaAnimationContainer pointer is invalid (hash={hash})", hash);
-                            if (v < 0) continue;
+                            return null;
-                            set.Add((ushort)v);
+                        }
+
+                        if (animContainer->Bindings.Length < 0 || animContainer->Bindings.Length > 10000)
+                        {
+                            _logger.LogDebug("Invalid bindings count {count} (hash={hash})", animContainer->Bindings.Length, hash);
+                            return null;
+                        }
+
+                        for (int i = 0; i < animContainer->Bindings.Length; i++)
+                        {
+                            var binding = animContainer->Bindings[i].ptr;
+                            if (binding == null)
+                                continue;
+
+                            if ((nint)binding == nint.Zero || !IsValidPointer((IntPtr)binding))
+                            {
+                                _logger.LogDebug("Skipping invalid binding at index {index} (hash={hash})", i, hash);
+                                continue;
+                            }
+
+                            var rawSkel = binding->OriginalSkeletonName.String;
+                            var skeletonKey = CanonicalizeSkeletonKey(rawSkel);
+                            if (string.IsNullOrEmpty(skeletonKey))
+                                continue;
+
+                            var boneTransform = binding->TransformTrackToBoneIndices;
+                            if (boneTransform.Length <= 0 || boneTransform.Length > 10000)
+                            {
+                                _logger.LogDebug("Invalid bone transform length {length} for skeleton {skel} (hash={hash})",
+                                    boneTransform.Length, skeletonKey, hash);
+                                continue;
+                            }
+
+                            if (!tempSets.TryGetValue(skeletonKey, out var set))
+                            {
+                                set = [];
+                                tempSets[skeletonKey] = set;
+                            }
+
+                            for (int boneIdx = 0; boneIdx < boneTransform.Length; boneIdx++)
+                            {
+                                var v = boneTransform[boneIdx];
+                                if (v < 0 || v > ushort.MaxValue)
+                                    continue;
+                                set.Add((ushort)v);
+                            }
                         }
                     }
                 }
             }
-        }
+            catch (SEHException ex)
-        catch (Exception ex)
-        {
-            _logger.LogWarning(ex, "Could not load havok file in {path}", tempHavokDataPath);
-            return null;
-        }
-        finally
-        {
-            if (tempHavokDataPathAnsi != IntPtr.Zero)
-                Marshal.FreeHGlobal(tempHavokDataPathAnsi);
-
-            try
             {
-                if (File.Exists(tempHavokDataPath))
+                _logger.LogError(ex, "SEH exception processing PAP file {hash} from {path}. Error code: 0x{code:X}",
-                    File.Delete(tempHavokDataPath);
+                    hash, tempHavokDataPath, ex.ErrorCode);
+                return null;
             }
             catch (Exception ex)
             {
-                _logger.LogTrace(ex, "Could not delete temporary havok file: {path}", tempHavokDataPath);
+                _logger.LogError(ex, "Managed exception loading havok file {hash} from {path}", hash, tempHavokDataPath);
+                return null;
             }
+            finally
+            {
+                if (tempHavokDataPathAnsi != IntPtr.Zero)
+                    Marshal.FreeHGlobal(tempHavokDataPathAnsi);
+
+                int retryCount = 3;
+                while (retryCount > 0 && File.Exists(tempHavokDataPath))
+                {
+                    try
+                    {
+                        File.Delete(tempHavokDataPath);
+                        break;
+                    }
+                    catch (IOException ex)
+                    {
+                        retryCount--;
+                        if (retryCount == 0)
+                        {
+                            _logger.LogDebug(ex, "Failed to delete temporary havok file after retries: {path}", tempHavokDataPath);
+                        }
+                        else
+                        {
+                            Thread.Sleep(50);
+                        }
+                    }
+                    catch (Exception ex)
+                    {
+                        _logger.LogDebug(ex, "Unexpected error deleting temporary havok file: {path}", tempHavokDataPath);
+                        break;
+                    }
+                }
+            }
+
+            if (tempSets.Count == 0)
+            {
+                _logger.LogDebug("No bone sets found in PAP file (hash={hash})", hash);
+                return null;
+            }
+
+            var output = new Dictionary<string, List<ushort>>(tempSets.Count, StringComparer.OrdinalIgnoreCase);
+            foreach (var (key, set) in tempSets)
+            {
+                if (set.Count == 0) continue;
+
+                var list = set.ToList();
+                list.Sort();
+                output[key] = list;
+            }
+
+            if (output.Count == 0)
+                return null;
+
+            _configService.Current.BonesDictionary[hash] = output;
+
+            if (persistToConfig)
+                _configService.Save();
+
+            return output;
         }
-
+        catch (Exception ex)
-        if (tempSets.Count == 0)
-            return null;
-
-        var output = new Dictionary<string, List<ushort>>(tempSets.Count, StringComparer.OrdinalIgnoreCase);
-        foreach (var (key, set) in tempSets)
         {
-            if (set.Count == 0) continue;
+            _logger.LogError(ex, "Outer exception reading PAP file (hash={hash})", hash);
-
-            var list = set.ToList();
-            list.Sort();
-            output[key] = list;
-        }
-
-        if (output.Count == 0)
             return null;
+        }
+    }
 
-        _configService.Current.BonesDictionary[hash] = output;
+    private static bool IsValidPointer(IntPtr ptr)
+    {
+        if (ptr == IntPtr.Zero)
+            return false;
 
-        if (persistToConfig)
+        try
-            _configService.Save();
+        {
-
+            _ = Marshal.ReadByte(ptr);
-        return output;
+            return true;
+        }
+        catch
+        {
+            return false;
+        }
     }
 
 

LightlessSync/UI/IntroUI.cs

@@ -6,12 +6,12 @@ using Dalamud.Utility;
 using LightlessSync.FileCache;
 using LightlessSync.LightlessConfiguration;
 using LightlessSync.LightlessConfiguration.Models;
-using LightlessSync.Localization;
 using LightlessSync.Services;
 using LightlessSync.Services.Mediator;
 using LightlessSync.Services.ServerConfiguration;
 using LightlessSync.Utils;
 using Microsoft.Extensions.Logging;
+using System.Globalization;
 using System.Numerics;
 using System.Text.RegularExpressions;
 
@@ -21,7 +21,7 @@ public partial class IntroUi : WindowMediatorSubscriberBase
 {
     private readonly LightlessConfigService _configService;
     private readonly CacheMonitor _cacheMonitor;
-    private readonly Dictionary<string, string> _languages = new(StringComparer.Ordinal) { { "English", "en" }, { "Deutsch", "de" }, { "Français", "fr" } };
+    private readonly Dictionary<string, string> _languages = new(StringComparer.Ordinal) { { "English", "en" }, { "Deutsch", "de" }, { "Français", "fr" }, { "中文", "zh"} };
     private readonly ServerConfigurationManager _serverConfigurationManager;
     private readonly DalamudUtilService _dalamudUtilService;
     private readonly UiSharedService _uiShared;
@@ -31,7 +31,6 @@ public partial class IntroUi : WindowMediatorSubscriberBase
     private string _secretKey = string.Empty;
     private string _timeoutLabel = string.Empty;
     private Task? _timeoutTask;
-    private string[]? _tosParagraphs;
     private bool _useLegacyLogin = false;
 
     public IntroUi(ILogger<IntroUi> logger, UiSharedService uiShared, LightlessConfigService configService,
@@ -50,8 +49,7 @@ public partial class IntroUi : WindowMediatorSubscriberBase
         WindowBuilder.For(this)
             .SetSizeConstraints(new Vector2(600, 400), new Vector2(600, 2000))
             .Apply();
-
+        
-        GetToSLocalization();
 
         Mediator.Subscribe<SwitchToMainUiMessage>(this, (_) => IsOpen = false);
         Mediator.Subscribe<SwitchToIntroUiMessage>(this, (_) =>
@@ -88,7 +86,7 @@ public partial class IntroUi : WindowMediatorSubscriberBase
                 {
                     for (int i = 60; i > 0; i--)
                     {
-                        _timeoutLabel = $"{Strings.ToS.ButtonWillBeAvailableIn} {i}s";
+                        _timeoutLabel = $"{Resources.Resources.ToSStrings_ButtonWillBeAvailableIn} {i}s";
                         await Task.Delay(TimeSpan.FromSeconds(1)).ConfigureAwait(false);
                     }
                 });
@@ -102,44 +100,46 @@ public partial class IntroUi : WindowMediatorSubscriberBase
             Vector2 textSize;
             using (_uiShared.UidFont.Push())
             {
-                textSize = ImGui.CalcTextSize(Strings.ToS.LanguageLabel);
+                textSize = ImGui.CalcTextSize(Resources.Resources.ToSStrings_LanguageLabel);
-                ImGui.TextUnformatted(Strings.ToS.AgreementLabel);
+                ImGui.TextUnformatted(Resources.Resources.ToSStrings_AgreementLabel);
             }
 
             ImGui.SameLine();
-            var languageSize = ImGui.CalcTextSize(Strings.ToS.LanguageLabel);
+            var languageSize = ImGui.CalcTextSize(Resources.Resources.ToSStrings_LanguageLabel);
             ImGui.SetCursorPosX(ImGui.GetWindowContentRegionMax().X - ImGui.GetWindowContentRegionMin().X - languageSize.X - 80);
             ImGui.SetCursorPosY(ImGui.GetCursorPosY() + textSize.Y / 2 - languageSize.Y / 2);
 
-            ImGui.TextUnformatted(Strings.ToS.LanguageLabel);
+            ImGui.TextUnformatted(Resources.Resources.ToSStrings_LanguageLabel);
             ImGui.SameLine();
             ImGui.SetCursorPosY(ImGui.GetCursorPosY() + textSize.Y / 2 - (languageSize.Y + ImGui.GetStyle().FramePadding.Y) / 2);
             ImGui.SetNextItemWidth(80);
             if (ImGui.Combo("", ref _currentLanguage, _languages.Keys.ToArray(), _languages.Count))
             {
-                GetToSLocalization(_currentLanguage);
+                var culture = new CultureInfo(_languages.Values.ToArray()[_currentLanguage]);
+                CultureInfo.DefaultThreadCurrentCulture = culture;
+                CultureInfo.DefaultThreadCurrentUICulture = culture;
             }
 
             ImGui.Separator();
             ImGui.SetWindowFontScale(1.5f);
-            string readThis = Strings.ToS.ReadLabel;
+            string readThis = Resources.Resources.ToSStrings_ReadLabel;
             textSize = ImGui.CalcTextSize(readThis);
             ImGui.SetCursorPosX(ImGui.GetWindowSize().X / 2 - textSize.X / 2);
             UiSharedService.ColorText(readThis, ImGuiColors.DalamudRed);
             ImGui.SetWindowFontScale(1.0f);
             ImGui.Separator();
 
-            UiSharedService.TextWrapped(_tosParagraphs![0]);
+            UiSharedService.TextWrapped(Resources.Resources.ToSStrings_Paragraph1);
-            UiSharedService.TextWrapped(_tosParagraphs![1]);
+            UiSharedService.TextWrapped(Resources.Resources.ToSStrings_Paragraph2);
-            UiSharedService.TextWrapped(_tosParagraphs![2]);
+            UiSharedService.TextWrapped(Resources.Resources.ToSStrings_Paragraph3);
-            UiSharedService.TextWrapped(_tosParagraphs![3]);
+            UiSharedService.TextWrapped(Resources.Resources.ToSStrings_Paragraph4);
-            UiSharedService.TextWrapped(_tosParagraphs![4]);
+            UiSharedService.TextWrapped(Resources.Resources.ToSStrings_Paragraph5);
-            UiSharedService.TextWrapped(_tosParagraphs![5]);
+            UiSharedService.TextWrapped(Resources.Resources.ToSStrings_Paragraph6);
 
             ImGui.Separator();
             if (_timeoutTask?.IsCompleted ?? true)
             {
-                if (ImGui.Button(Strings.ToS.AgreeLabel + "##toSetup"))
+                if (ImGui.Button(Resources.Resources.ToSStrings_AgreeLabel + "##toSetup"))
                 {
                     _configService.Current.AcceptedAgreement = true;
                     _configService.Save();
@@ -349,16 +349,6 @@ public partial class IntroUi : WindowMediatorSubscriberBase
         }
     }
 
-    private void GetToSLocalization(int changeLanguageTo = -1)
-    {
-        if (changeLanguageTo != -1)
-        {
-            _uiShared.LoadLocalization(_languages.ElementAt(changeLanguageTo).Value);
-        }
-
-        _tosParagraphs = [Strings.ToS.Paragraph1, Strings.ToS.Paragraph2, Strings.ToS.Paragraph3, Strings.ToS.Paragraph4, Strings.ToS.Paragraph5, Strings.ToS.Paragraph6];
-    }
-
     [GeneratedRegex("^[A-F0-9]{64}$", RegexOptions.Compiled | RegexOptions.CultureInvariant)]
     private static partial Regex SecretRegex();
 }

LightlessSync/UI/SettingsUi.cs

@@ -4812,7 +4812,7 @@ public class SettingsUi : WindowMediatorSubscriberBase
             ImGui.TextColored(UIColors.Get("LightlessBlue"),
                 _apiController.OnlineUsers.ToString(CultureInfo.InvariantCulture));
             ImGui.SameLine();
-            ImGui.TextUnformatted("Users Online");
+            ImGui.TextUnformatted(Resources.Resources.Users_Online);
             ImGui.SameLine();
             ImGui.TextUnformatted(")");
         }

LightlessSync/UI/UISharedService.cs

@@ -18,7 +18,6 @@ using LightlessSync.Interop.Ipc;
 using LightlessSync.Interop.Ipc.Framework;
 using LightlessSync.LightlessConfiguration;
 using LightlessSync.LightlessConfiguration.Models;
-using LightlessSync.Localization;
 using LightlessSync.PlayerData.Pairs;
 using LightlessSync.Services;
 using LightlessSync.Services.Mediator;
@@ -1468,12 +1467,6 @@ public partial class UiSharedService : DisposableMediatorSubscriberBase
         return false;
     }
 
-    public void LoadLocalization(string languageCode)
-    {
-        _localization.SetupWithLangCode(languageCode);
-        Strings.ToS = new Strings.ToSStrings();
-    }
-
     internal static void DistanceSeparator()
     {
         ImGuiHelpers.ScaledDummy(5);