add more checks

Co-authored-by: azyges <aaaaaa@aaa.aaa>
Co-authored-by: cake <admin@cakeandbanana.nl>
Reviewed-on: #134
Reviewed-by: defnotken <defnotken@noreply.git.lightless-sync.org>

LightlessSync/LightlessSync.csproj

@@ -3,7 +3,7 @@
   <PropertyGroup>
     <Authors></Authors>
     <Company></Company>
-    <Version>2.0.3</Version>
+    <Version>2.0.2.71</Version>
     <Description></Description>
     <Copyright></Copyright>
     <PackageProjectUrl>https://github.com/Light-Public-Syncshells/LightlessClient</PackageProjectUrl>

LightlessSync/Services/DalamudUtilService.cs

@@ -955,7 +955,13 @@ public class DalamudUtilService : IHostedService, IMediatorSubscriber
 
     private unsafe void CheckCharacterForDrawing(nint address, string characterName)
     {
+        if (address == nint.Zero)
+            return;
+
         var gameObj = (GameObject*)address;
+
+        if (gameObj == null || gameObj->ObjectKind == 0)
+            return;
         var drawObj = gameObj->DrawObject;
         bool isDrawing = false;
         bool isDrawingChanged = false;
@@ -1052,16 +1058,28 @@ public class DalamudUtilService : IHostedService, IMediatorSubscriber
 
                         if (!IsAnythingDrawing)
                         {
-                            var gameObj = (GameObject*)playerAddress;
+                            try
-                            var currentName = gameObj != null ? gameObj->NameString ?? string.Empty : string.Empty;
+                            {
-                            var charaName = string.IsNullOrEmpty(currentName) ? actor.Name : currentName;
+                                var gameObj = (GameObject*)playerAddress;
-                            CheckCharacterForDrawing(playerAddress, charaName);
+
-                            if (IsAnythingDrawing)
+                                if (gameObj == null || gameObj->ObjectKind == 0)
-                                break;
+                                {
-                        }
+                                    continue;
-                        else
+                                }
-                        {
+
-                            break;
+                                var currentName = gameObj->NameString ?? string.Empty;
+                                var charaName = string.IsNullOrEmpty(currentName) ? actor.Name : currentName;
+
+                                CheckCharacterForDrawing(playerAddress, charaName);
+
+                                if (IsAnythingDrawing)
+                                    break;
+                            }
+                            catch (AccessViolationException ex)
+                            {
+                                _logger.LogWarning(ex, "Memory access violation reading character at {addr}", playerAddress.ToString("X"));
+                                continue;
+                            }
                         }
                     }
                 });