fix task register

LightlessSync/PlayerData/Factories/PlayerDataFactory.cs

@@ -9,10 +9,10 @@ using LightlessSync.PlayerData.Data;
 using LightlessSync.PlayerData.Handlers;
 using LightlessSync.Services;
 using LightlessSync.Services.Mediator;
+using LightlessSync.Utils;
 using Microsoft.Extensions.Logging;
 using System.Collections.Concurrent;
 using System.Diagnostics;
-using System.Runtime.ExceptionServices;
 using System.Runtime.InteropServices;
 
 namespace LightlessSync.PlayerData.Factories;
@@ -34,7 +34,7 @@ public class PlayerDataFactory
     private const int _maxTransientResolvedEntries = 1000;
 
     // Character build caches
-    private readonly ConcurrentDictionary<nint, Task<CharacterDataFragment>> _characterBuildInflight = new();
+    private readonly TaskRegistry<nint> _characterBuildInflight = new();
     private readonly ConcurrentDictionary<nint, CacheEntry> _characterBuildCache = new();
 
     // Time out thresholds
@@ -170,10 +170,10 @@ public class PlayerDataFactory
     {
         var key = obj.Address;
 
-        if (_characterBuildCache.TryGetValue(key, out var cached) && IsCacheFresh(cached) && !_characterBuildInflight.ContainsKey(key))
+        if (_characterBuildCache.TryGetValue(key, out CacheEntry cached) && IsCacheFresh(cached) && !_characterBuildInflight.TryGetExisting(key, out _))
             return cached.Fragment;
 
-        var buildTask = _characterBuildInflight.GetOrAdd(key, _ => BuildAndCacheAsync(obj, key));
+        Task<CharacterDataFragment> buildTask = _characterBuildInflight.GetOrStart(key, () => BuildAndCacheAsync(obj, key));
 
         if (_characterBuildCache.TryGetValue(key, out cached))
         {
@@ -189,20 +189,13 @@ public class PlayerDataFactory
 
     private async Task<CharacterDataFragment> BuildAndCacheAsync(GameObjectHandler obj, nint key)
     {
-        try
+        using var cts = new CancellationTokenSource(_hardBuildTimeout);
-        {
+        CharacterDataFragment fragment = await CreateCharacterDataInternal(obj, cts.Token).ConfigureAwait(false);
-            using var cts = new CancellationTokenSource(_hardBuildTimeout);
-            var fragment = await CreateCharacterDataInternal(obj, cts.Token).ConfigureAwait(false);
 
-            _characterBuildCache[key] = new CacheEntry(fragment, DateTime.UtcNow);
+        _characterBuildCache[key] = new CacheEntry(fragment, DateTime.UtcNow);
-            PruneCharacterCacheIfNeeded();
+        PruneCharacterCacheIfNeeded();
 
-            return fragment;
+        return fragment;
-        }
-        finally
-        {
-            _characterBuildInflight.TryRemove(key, out _);
-        }
     }
 
     private void PruneCharacterCacheIfNeeded()

LightlessSync/Utils/TaskRegistry.cs

@@ -1,37 +1,81 @@
 using System.Collections.Concurrent;
 
-
 namespace LightlessSync.Utils;
 
 public sealed class TaskRegistry<HandleType> where HandleType : notnull
 {
-    private readonly ConcurrentDictionary<HandleType, ActiveTask> _activeTasks = new();
+    private readonly ConcurrentDictionary<HandleType, Lazy<Task>> _activeTasks = new();
 
     public Task GetOrStart(HandleType handle, Func<Task> taskFactory)
-    {
+        => GetOrStartInternal(handle, taskFactory);
-        ActiveTask entry = _activeTasks.GetOrAdd(handle, i => new ActiveTask(() => ExecuteAndRemove(i, taskFactory)));
-        return entry.EnsureStarted();
-    }
 
     public Task<T> GetOrStart<T>(HandleType handle, Func<Task<T>> taskFactory)
-    {
+        => GetOrStartInternal(handle, taskFactory);
-        ActiveTask entry = _activeTasks.GetOrAdd(handle, i => new ActiveTask(() => ExecuteAndRemove(i, taskFactory)));
-        return (Task<T>)entry.EnsureStarted();
-    }
 
     public bool TryGetExisting(HandleType handle, out Task task)
     {
-        if (_activeTasks.TryGetValue(handle, out ActiveTask? entry))
+        if (_activeTasks.TryGetValue(handle, out Lazy<Task>? entry))
         {
-            task = entry.EnsureStarted();
+            task = entry.Value;
-            return true;
+            if (!task.IsCompleted)
+            {
+                return true;
+            }
+
+            _activeTasks.TryRemove(new KeyValuePair<HandleType, Lazy<Task>>(handle, entry));
         }
 
         task = Task.CompletedTask;
         return false;
     }
 
-    private async Task ExecuteAndRemove(HandleType handle, Func<Task> taskFactory)
+    private Task GetOrStartInternal(HandleType handle, Func<Task> taskFactory)
+    {
+        while (true)
+        {
+            Lazy<Task> entry = _activeTasks.GetOrAdd(handle, _ => CreateEntry(handle, taskFactory));
+            Task task = entry.Value;
+
+            if (!task.IsCompleted)
+            {
+                return task;
+            }
+
+            _activeTasks.TryRemove(new KeyValuePair<HandleType, Lazy<Task>>(handle, entry));
+        }
+    }
+
+    private Task<T> GetOrStartInternal<T>(HandleType handle, Func<Task<T>> taskFactory)
+    {
+        while (true)
+        {
+            Lazy<Task> entry = _activeTasks.GetOrAdd(handle, _ => CreateEntry(handle, taskFactory));
+            Task task = entry.Value;
+
+            if (!task.IsCompleted)
+            {
+                return (Task<T>)task;
+            }
+
+            _activeTasks.TryRemove(new KeyValuePair<HandleType, Lazy<Task>>(handle, entry));
+        }
+    }
+
+    private Lazy<Task> CreateEntry(HandleType handle, Func<Task> taskFactory)
+    {
+        Lazy<Task> entry = null!;
+        entry = new Lazy<Task>(() => ExecuteAndRemove(handle, entry, taskFactory), LazyThreadSafetyMode.ExecutionAndPublication);
+        return entry;
+    }
+
+    private Lazy<Task> CreateEntry<T>(HandleType handle, Func<Task<T>> taskFactory)
+    {
+        Lazy<Task> entry = null!;
+        entry = new Lazy<Task>(() => ExecuteAndRemove(handle, entry, taskFactory), LazyThreadSafetyMode.ExecutionAndPublication);
+        return entry;
+    }
+
+    private async Task ExecuteAndRemove(HandleType handle, Lazy<Task> entry, Func<Task> taskFactory)
     {
         try
         {
@@ -39,11 +83,11 @@ public sealed class TaskRegistry<HandleType> where HandleType : notnull
         }
         finally
         {
-            _activeTasks.TryRemove(handle, out _);
+            _activeTasks.TryRemove(new KeyValuePair<HandleType, Lazy<Task>>(handle, entry));
         }
     }
 
-    private async Task<T> ExecuteAndRemove<T>(HandleType handle, Func<Task<T>> taskFactory)
+    private async Task<T> ExecuteAndRemove<T>(HandleType handle, Lazy<Task> entry, Func<Task<T>> taskFactory)
     {
         try
         {
@@ -51,31 +95,7 @@ public sealed class TaskRegistry<HandleType> where HandleType : notnull
         }
         finally
         {
-            _activeTasks.TryRemove(handle, out _);
+            _activeTasks.TryRemove(new KeyValuePair<HandleType, Lazy<Task>>(handle, entry));
-        }
-    }
-
-    private sealed class ActiveTask
-    {
-        private readonly object _gate = new();
-        private readonly Func<Task> _starter;
-        private Task? _cached;
-
-        public ActiveTask(Func<Task> starter)
-        {
-            _starter = starter;
-        }
-
-        public Task EnsureStarted()
-        {
-            lock (_gate)
-            {
-                if (_cached == null || _cached.IsCompleted)
-                {
-                    _cached = _starter();
-                }
-                return _cached;
-            }
         }
     }
 }