Fix moderator status on broadcast

LightlessSyncServer/LightlessSyncServer/Hubs/LightlessHub.Groups.cs

@@ -28,72 +28,25 @@ public partial class LightlessHub
         var (userHasRights, group) = await TryValidateGroupModeratorOrOwner(dto.Group.GID).ConfigureAwait(false);
         if (!userHasRights) return;
 
-        var targetUid = dto.User.UID?.Trim();
-        if (string.IsNullOrWhiteSpace(targetUid)) return;
+        var (userExists, groupPair) = await TryValidateUserInGroup(dto.Group.GID, dto.User.UID).ConfigureAwait(false);
+        if (!userExists) return;
 
-        if (string.Equals(group.OwnerUID, targetUid, StringComparison.Ordinal))
-            return;
+        if (groupPair.IsModerator || string.Equals(group.OwnerUID, dto.User.UID, StringComparison.Ordinal)) return;
 
-        var groupPair = await DbContext.GroupPairs
-            .Include(p => p.GroupUser)
-            .SingleOrDefaultAsync(p => p.GroupGID == dto.Group.GID && p.GroupUserUID == targetUid, cancellationToken: RequestAbortedToken).ConfigureAwait(false);
-
-        if (groupPair?.IsModerator == true)
-            return;
-
-        var now = DateTime.UtcNow;
-
-        var existingBan = await DbContext.Set<GroupBan>().SingleOrDefaultAsync(b => b.GroupGID == dto.Group.GID && b.BannedUserUID == targetUid, cancellationToken: RequestAbortedToken).ConfigureAwait(false);
-        var userExists = await DbContext.Users.AsNoTracking().AnyAsync(u => u.UID == targetUid || u.Alias == targetUid, RequestAbortedToken).ConfigureAwait(false);
-
-        if (!userExists && existingBan == null)
-            return;
-
-        const string marker = " (Alias at time of ban:";
-        string suffix;
-
-        if (existingBan?.BannedReason is { } existingReason)
-        {
-            var idx = existingReason.IndexOf(marker, StringComparison.Ordinal);
-            suffix = idx >= 0 ? existingReason.Substring(startIndex: idx) : string.Empty;
-        }
-        else
-        {
-            var alias = groupPair?.GroupUser?.Alias;
-            alias = string.IsNullOrWhiteSpace(alias) ? "-" : alias;
-            suffix = $" (Alias at time of ban: {alias})";
-        }
-
-        var baseReason = (reason ?? string.Empty).Trim();
-        var finalReason = string.IsNullOrEmpty(suffix) ? baseReason : (baseReason + suffix);
-
-        if (existingBan != null)
-        {
-            existingBan.BannedByUID = UserUID;
-            existingBan.BannedReason = finalReason;
-
-            DbContext.Update(existingBan);
-        }
-        else
-        {
-            var ban = new GroupBan
+        var alias = string.IsNullOrEmpty(groupPair.GroupUser.Alias) ? "-" : groupPair.GroupUser.Alias;
+        var ban = new GroupBan()
         {
             BannedByUID = UserUID,
-                BannedReason = finalReason,
-                BannedOn = now,
-                BannedUserUID = targetUid,
+            BannedReason = $"{reason} (Alias at time of ban: {alias})",
+            BannedOn = DateTime.UtcNow,
+            BannedUserUID = dto.User.UID,
             GroupGID = dto.Group.GID,
         };
 
         DbContext.Add(ban);
-        }
+        await DbContext.SaveChangesAsync().ConfigureAwait(false);
 
-        await DbContext.SaveChangesAsync(RequestAbortedToken).ConfigureAwait(false);
-
-        if (groupPair != null)
-        {
         await GroupRemoveUser(dto).ConfigureAwait(false);
-        }
 
         _logger.LogCallInfo(LightlessHubLogger.Args(dto, "Success"));
     }
@@ -447,9 +400,9 @@ public partial class LightlessHub
 
         var banEntries = await DbContext.GroupBans.Include(b => b.BannedUser).Where(g => g.GroupGID == dto.Group.GID).AsNoTracking().ToListAsync(cancellationToken: RequestAbortedToken).ConfigureAwait(false);
 
-        List<BannedGroupUserDto> bannedGroupUsers = [.. banEntries.Select(b =>
+        List<BannedGroupUserDto> bannedGroupUsers = banEntries.Select(b =>
             new BannedGroupUserDto(group.ToGroupData(), b.BannedUser.ToUserData(), b.BannedReason, b.BannedOn,
-                b.BannedByUID))];
+                b.BannedByUID)).ToList();
 
         _logger.LogCallInfo(LightlessHubLogger.Args(dto, bannedGroupUsers.Count));
 

LightlessSyncServer/LightlessSyncServer/Services/LightlessCensus.cs

@@ -72,7 +72,7 @@ public class LightlessCensus : IHostedService
 
         Dictionary<ushort, short> worldDcs = new();
 
-        var dcs = await client.GetStringAsync("https://raw.githubusercontent.com/xivapi/ffxiv-datamining/master/csv/en/WorldDCGroupType.csv", cancellationToken).ConfigureAwait(false);
+        var dcs = await client.GetStringAsync("https://raw.githubusercontent.com/xivapi/ffxiv-datamining/master/csv/WorldDCGroupType.csv", cancellationToken).ConfigureAwait(false);
         // dc: https://raw.githubusercontent.com/xivapi/ffxiv-datamining/master/csv/WorldDCGroupType.csv
         // id, name, region
 
@@ -92,7 +92,7 @@ public class LightlessCensus : IHostedService
             _dcs[id] = name;
         }
 
-        var worlds = await client.GetStringAsync("https://raw.githubusercontent.com/xivapi/ffxiv-datamining/master/csv/en/World.csv", cancellationToken).ConfigureAwait(false);
+        var worlds = await client.GetStringAsync("https://raw.githubusercontent.com/xivapi/ffxiv-datamining/master/csv/World.csv", cancellationToken).ConfigureAwait(false);
         // world: https://raw.githubusercontent.com/xivapi/ffxiv-datamining/master/csv/World.csv
         // id, internalname, name, region, usertype, datacenter, ispublic
 
@@ -114,7 +114,7 @@ public class LightlessCensus : IHostedService
             _logger.LogInformation("World: ID: {id}, Name: {name}, DC: {dc}", id, name, dc);
         }
 
-        var races = await client.GetStringAsync("https://raw.githubusercontent.com/xivapi/ffxiv-datamining/master/csv/en/Race.csv", cancellationToken).ConfigureAwait(false);
+        var races = await client.GetStringAsync("https://raw.githubusercontent.com/xivapi/ffxiv-datamining/master/csv/Race.csv", cancellationToken).ConfigureAwait(false);
         // race: https://raw.githubusercontent.com/xivapi/ffxiv-datamining/master/csv/Race.csv
         // id, masc name, fem name, other crap I don't care about
 
@@ -134,7 +134,7 @@ public class LightlessCensus : IHostedService
             _logger.LogInformation("Race: ID: {id}, Name: {name}", id, name);
         }
 
-        var tribe = await client.GetStringAsync("https://raw.githubusercontent.com/xivapi/ffxiv-datamining/master/csv/en/Tribe.csv", cancellationToken).ConfigureAwait(false);
+        var tribe = await client.GetStringAsync("https://raw.githubusercontent.com/xivapi/ffxiv-datamining/master/csv/Tribe.csv", cancellationToken).ConfigureAwait(false);
         // tribe: https://raw.githubusercontent.com/xivapi/ffxiv-datamining/master/csv/Tribe.csv
         // id masc name, fem name, other crap I don't care about
 

LightlessSyncServer/LightlessSyncServer/Services/PruneService.cs

@@ -2,19 +2,15 @@
 using LightlessSyncShared.Data;
 using LightlessSyncShared.Models;
 using Microsoft.EntityFrameworkCore;
-using StackExchange.Redis.Extensions.Core.Abstractions;
 
 namespace LightlessSyncServer.Services
 {
-    public class PruneService(LightlessDbContext dbContext, IRedisDatabase redis) : IPruneService
+    public class PruneService(LightlessDbContext dbContext) : IPruneService
     {
         private readonly LightlessDbContext _dbContext = dbContext;
-        private readonly IRedisDatabase _redis = redis;
 
         public async Task<int> CountPrunableUsersAsync(string groupGid, int days, CancellationToken ct)
         {
-            var onlineUids = await GetOnlineUidsAsync().ConfigureAwait(false);
-
             var allGroupUsers = await _dbContext.GroupPairs
                 .Include(p => p.GroupUser)
                 .Include(p => p.Group)
@@ -24,14 +20,17 @@ namespace LightlessSyncServer.Services
             var inactivitySpan = GetInactivitySpan(days);
             var now = DateTime.UtcNow;
 
-            var usersToPrune = GetPruneUserList(allGroupUsers, onlineUids, inactivitySpan, now);
-            return usersToPrune.Count;
+            var usersToPrune = allGroupUsers.Where(p =>
+                !p.IsPinned &&
+                !p.IsModerator &&
+                !string.Equals(p.Group.OwnerUID, p.GroupUserUID, StringComparison.Ordinal) &&
+                p.GroupUser.LastLoggedIn < now - inactivitySpan);
+
+            return usersToPrune.Count();
         }
 
         public async Task<IReadOnlyList<GroupPair>> ExecutePruneAsync(string groupGid, int days, CancellationToken ct)
         {
-            var onlineUids = await GetOnlineUidsAsync().ConfigureAwait(false);
-
             var allGroupUsers = await _dbContext.GroupPairs
                 .Include(p => p.GroupUser)
                 .Include(p => p.Group)
@@ -41,7 +40,12 @@ namespace LightlessSyncServer.Services
             var inactivitySpan = GetInactivitySpan(days);
             var now = DateTime.UtcNow;
 
-            var usersToPrune = GetPruneUserList(allGroupUsers, onlineUids, inactivitySpan, now);
+            var usersToPrune = allGroupUsers.Where(p =>
+                !p.IsPinned &&
+                !p.IsModerator &&
+                !string.Equals(p.Group.OwnerUID, p.GroupUserUID, StringComparison.Ordinal) &&
+                p.GroupUser.LastLoggedIn < now - inactivitySpan)
+                .ToList();
 
             _dbContext.GroupPairs.RemoveRange(usersToPrune);
             await _dbContext.SaveChangesAsync(ct).ConfigureAwait(false);
@@ -49,52 +53,8 @@ namespace LightlessSyncServer.Services
             return usersToPrune;
         }
 
-        private static List<GroupPair> GetPruneUserList(
-            List<GroupPair> allGroupUsers,
-            HashSet<string> onlineUids,
-            TimeSpan inactivitySpan,
-            DateTime now)
-        {
-            return
-            [
-                .. allGroupUsers.Where(p =>
-                    !p.IsPinned &&
-                    !p.IsModerator &&
-                    !string.Equals(p.Group.OwnerUID, p.GroupUserUID, StringComparison.Ordinal) &&
-                    !onlineUids.Contains(p.GroupUserUID) &&
-                    p.GroupUser.LastLoggedIn < now - inactivitySpan),
-            ];
-        }
-
-        private async Task<HashSet<string>> GetOnlineUidsAsync()
-        {
-            var keys = await _redis.SearchKeysAsync("UID:*").ConfigureAwait(false);
-
-            var set = new HashSet<string>(StringComparer.Ordinal);
-
-            foreach (var k in keys)
-            {
-                if (string.IsNullOrEmpty(k)) continue;
-
-                const string prefix = "UID:";
-                if (k.StartsWith(prefix, StringComparison.Ordinal))
-                {
-                    var uid = k.Substring(prefix.Length);
-                    if (!string.IsNullOrEmpty(uid))
-                        set.Add(uid);
-                }
-                else
-                {
-                    var idx = k.IndexOf(':', StringComparison.Ordinal);
-                    if (idx >= 0 && idx < k.Length - 1)
-                        set.Add(k[(idx + 1)..]);
-                }
-            }
-
-            return set;
-        }
-
-        private static TimeSpan GetInactivitySpan(int days) =>
-            days == 0 ? TimeSpan.FromHours(2) : TimeSpan.FromDays(days);
+        private static TimeSpan GetInactivitySpan(int days) => days == 0
+                ? TimeSpan.FromMinutes(15)
+                : TimeSpan.FromDays(days);
     }
 }

LightlessSyncServer/LightlessSyncServer/Worker/AutoPruneWorker.cs

@@ -24,7 +24,7 @@ namespace LightlessSyncServer.Worker
                         var hubContext = scope.ServiceProvider.GetRequiredService<IHubContext<LightlessHub>>();
 
                         var groups = await db.Groups
-                            .Where(g => g.AutoPruneEnabled)
+                            .Where(g => g.AutoPruneEnabled && g.AutoPruneDays > 0)
                             .ToListAsync(stoppingToken).ConfigureAwait(false);
 
                         foreach (var group in groups)

LightlessSyncServer/LightlessSyncStaticFilesServer/Controllers/ShardServerFilesController.cs

@@ -20,14 +20,13 @@ public class ShardServerFilesController : ControllerBase
     [AllowAnonymous]
     public async Task<IActionResult> DownloadFileDirect(string hash, [FromQuery] long expires, [FromQuery] string signature)
     {
-        var result = _cdnDownloadsService.GetDownloadWithCacheCheck(hash, expires, signature);
+        var result = await _cdnDownloadsService.GetDownloadAsync(hash, expires, signature).ConfigureAwait(false);
 
         return result.Status switch
         {
             CDNDownloadsService.ResultStatus.Disabled => NotFound(),
             CDNDownloadsService.ResultStatus.Unauthorized => Unauthorized(),
             CDNDownloadsService.ResultStatus.NotFound => NotFound(),
-            CDNDownloadsService.ResultStatus.Downloading => StatusCode(503),
             CDNDownloadsService.ResultStatus.Success => PhysicalFile(result.File!.FullName, "application/octet-stream"),
             _ => NotFound()
         };

LightlessSyncServer/LightlessSyncStaticFilesServer/Services/CDNDownloadsService.cs

@@ -10,8 +10,7 @@ public class CDNDownloadsService
         Disabled,
         Unauthorized,
         NotFound,
-        Success,
-        Downloading
+        Success
     }
 
     public readonly record struct Result(ResultStatus Status, FileInfo? File);
@@ -54,32 +53,4 @@ public class CDNDownloadsService
 
         return new Result(ResultStatus.Success, fileInfo);
     }
-
-    public Result GetDownloadWithCacheCheck(string hash, long expiresUnixSeconds, string signature)
-    {
-        if (!_cdnDownloadUrlService.DirectDownloadsEnabled)
-        {
-            return new Result(ResultStatus.Disabled, null);
-        }
-
-        if (string.IsNullOrEmpty(signature) || string.IsNullOrEmpty(hash))
-        {
-            return new Result(ResultStatus.Unauthorized, null);
-        }
-
-        hash = hash.ToUpperInvariant();
-
-        if (!_cdnDownloadUrlService.TryValidateSignature(hash, expiresUnixSeconds, signature))
-        {
-            return new Result(ResultStatus.Unauthorized, null);
-        }
-
-        var fileInfo = _cachedFileProvider.TryGetLocalFileInfo(hash);
-        if (fileInfo == null)
-        {
-            return new Result(ResultStatus.Downloading, null);
-        }
-
-        return new Result(ResultStatus.Success, fileInfo);
-    }
 }

LightlessSyncServer/LightlessSyncStaticFilesServer/Services/CachedFileProvider.cs

@@ -219,27 +219,4 @@ public sealed class CachedFileProvider : IDisposable
     {
         return hashes.Exists(_currentTransfers.Keys.Contains);
     }
-
-    public FileInfo? TryGetLocalFileInfo(string hash)
-    {
-        var fi = FilePathUtil.GetFileInfoForHash(_hotStoragePath, hash);
-        if (fi != null)
-        {
-            return GetLocalFilePath(hash);
-        }
-
-        _ = Task.Run(async () =>
-        {
-            try
-            {
-                await DownloadFileWhenRequired(hash).ConfigureAwait(false);
-            }
-            catch (Exception ex)
-            {
-                _logger.LogWarning(ex, "Download failed for {hash}", hash);
-            }
-        });
-
-        return null;
-    }
 }