All checks were successful
Tag and Release Lightless / tag-and-release (push) Successful in 2m9s
# Patchnotes 2.1.0 The changes in this update are more than just "patches". With a new UI, a new feature, and a bunch of bug fixes, improvements and a new member on the dev team, we thought this was more of a minor update. We would like to introduce @tsubasahane of MareCN to the team! We’re happy to work with them to bring Lightless and its features to the CN client as well as having another talented dev bring features and ideas to us. Speaking of which: # Location Sharing (Big shout out to @tsubasahane for bringing this feature) - Are you TIRED of scrambling to find the address of the venue you're in to share with your friends? We are introducing Location Sharing! An optional feature where you can share your location with direct pairs temporarily [30 minutes, 1 hour, 3 hours] minutes or until you turn it off for them. That's up to you! [#125](<#125>) [#49](<Lightless-Sync/LightlessServer#49>) - To share your location with a pair, click the three dots beside the pair and choose a duration to share with them. [#125](<#125>) [#49](<Lightless-Sync/LightlessServer#49>) - To view the location of someone who's shared with you, simply hover over the globe icon! [#125](<#125>) [#49](<Lightless-Sync/LightlessServer#49>) [1] # Model Optimization (Mesh Decimating) - This new option can automatically “simplify” incoming character meshes to help performance by reducing triangle counts. You choose how strong the reduction is (default/recommended is 80%). [#131](<#131>) - Decimation only kicks in when a mesh is above a certain triangle threshold, and only for the items that qualify for it and you selected for. [#131](<#131>) - Hair meshes is always excluded, since simplifying hair meshes is very prone to breaking. - You can find everything under Settings → Performance → Model Optimization. [#131](<#131>) + ** IF YOU HAVE USED DECIMATION IN TESTING, PLEASE CLEAR YOUR CACHE ❗ ** [2] # Animation (PAP) Validation (Safer animations) - Lightless now checks your currently animations to see if they work with your local skeleton/bone mod. If an animation matches, it’s included in what gets sent to other players. If it doesn’t, Lightless will skip it and write a warning to your log showing how many were skipped due to skeleton changes. Its defaulted to Unsafe (off). turn it on if you experience crashes from others users. [#131](<#131>) - Lightless also does the same kind of check for incoming animation files, to make sure they match the body/skeleton they were sent with. [#131](<#131>) - Because these checks can sometimes be a little picky, you can adjust how strict they are in Settings -> General -> Animation & Bones to reduce false positives. [#131](<#131>) # UI Changes (Thanks to @kyuwu for UI Changes) - The top part of the main screen has gotten a makeover. You can adjust the colors of the gradiant in the Color settings of Lightless. [#127](<#127>) [3] - Settings have gotten some changes as well to make this change more universal, and will use the same color settings. [#127](<#127>) - The particle effects of the gradient are toggleable in 'Settings -> UI -> Behavior' [#127](<#127>) - Instead of showing download/upload on bottom of Main UI, it will show VRAM usage and triangles with their optimization options next to it [#138](<#138>) # LightFinder / ShellFinder - UI Changes that follow our new design follow the color codes for the Gradient top as the main screen does. [#127](<#127>) [4] Co-authored-by: defnotken <itsdefnotken@gmail.com> Co-authored-by: azyges <aaaaaa@aaa.aaa> Co-authored-by: cake <admin@cakeandbanana.nl> Co-authored-by: Tsubasa <tsubasa@noreply.git.lightless-sync.org> Co-authored-by: choco <choco@patat.nl> Co-authored-by: celine <aaa@aaa.aaa> Co-authored-by: celine <celine@noreply.git.lightless-sync.org> Co-authored-by: Tsubasahane <wozaiha@gmail.com> Co-authored-by: cake <cake@noreply.git.lightless-sync.org> Reviewed-on: #123
242 lines
6.4 KiB
C#
242 lines
6.4 KiB
C#
using Microsoft.Extensions.Logging;
|
|
using System.Diagnostics;
|
|
using System.IO.Pipes;
|
|
using System.Text.Json;
|
|
|
|
namespace LightlessSync.FileCache;
|
|
|
|
internal sealed class ExternalCompactionExecutor : ICompactionExecutor, IDisposable
|
|
{
|
|
private readonly ILogger<ExternalCompactionExecutor> _logger;
|
|
private readonly ICompactorContext _context;
|
|
private readonly TimeSpan _timeout = TimeSpan.FromMinutes(5);
|
|
private readonly string _pipeName;
|
|
private Process? _workerProcess;
|
|
private bool _disposed;
|
|
private readonly object _sync = new();
|
|
|
|
public ExternalCompactionExecutor(ILogger<ExternalCompactionExecutor> logger, ICompactorContext context)
|
|
{
|
|
_logger = logger;
|
|
_context = context;
|
|
_pipeName = $"LightlessCompactor-{Environment.ProcessId}";
|
|
}
|
|
|
|
public bool TryCompact(string filePath)
|
|
{
|
|
if (string.IsNullOrWhiteSpace(filePath) || !File.Exists(filePath))
|
|
return false;
|
|
|
|
if (!EnsureWorkerRunning())
|
|
return false;
|
|
|
|
try
|
|
{
|
|
var request = new CompactorRequest
|
|
{
|
|
Type = "compact",
|
|
Path = filePath
|
|
};
|
|
|
|
return SendRequest(request, out var response) && response?.Success == true;
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
_logger.LogWarning(ex, "External compactor failed for {file}", filePath);
|
|
return false;
|
|
}
|
|
}
|
|
|
|
public void Dispose()
|
|
{
|
|
if (_disposed)
|
|
return;
|
|
|
|
_disposed = true;
|
|
|
|
try
|
|
{
|
|
SendRequest(new CompactorRequest { Type = "shutdown" }, out _);
|
|
}
|
|
catch
|
|
{
|
|
// ignore
|
|
}
|
|
|
|
lock (_sync)
|
|
{
|
|
if (_workerProcess is null)
|
|
return;
|
|
|
|
TryKill(_workerProcess);
|
|
_workerProcess.Dispose();
|
|
_workerProcess = null;
|
|
}
|
|
}
|
|
|
|
private bool EnsureWorkerRunning()
|
|
{
|
|
lock (_sync)
|
|
{
|
|
if (_workerProcess is { HasExited: false })
|
|
return true;
|
|
|
|
_workerProcess?.Dispose();
|
|
_workerProcess = null;
|
|
|
|
var workerPath = ResolveWorkerPath();
|
|
if (string.IsNullOrEmpty(workerPath))
|
|
return false;
|
|
|
|
var args = BuildArguments();
|
|
var startInfo = new ProcessStartInfo
|
|
{
|
|
FileName = workerPath,
|
|
Arguments = args,
|
|
CreateNoWindow = true,
|
|
UseShellExecute = false,
|
|
RedirectStandardOutput = true,
|
|
RedirectStandardError = true
|
|
};
|
|
|
|
var process = new Process { StartInfo = startInfo };
|
|
if (!process.Start())
|
|
return false;
|
|
|
|
TrySetLowPriority(process);
|
|
_ = DrainAsync(process.StandardOutput, "stdout");
|
|
_ = DrainAsync(process.StandardError, "stderr");
|
|
|
|
_workerProcess = process;
|
|
return true;
|
|
}
|
|
}
|
|
|
|
private bool SendRequest(CompactorRequest request, out CompactorResponse? response)
|
|
{
|
|
response = null;
|
|
using var pipe = new NamedPipeClientStream(".", _pipeName, PipeDirection.InOut, PipeOptions.Asynchronous);
|
|
|
|
try
|
|
{
|
|
pipe.Connect((int)_timeout.TotalMilliseconds);
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
_logger.LogDebug(ex, "Compactor pipe connection failed.");
|
|
return false;
|
|
}
|
|
|
|
using var writer = new StreamWriter(pipe) { AutoFlush = true };
|
|
using var reader = new StreamReader(pipe);
|
|
|
|
var payload = JsonSerializer.Serialize(request);
|
|
writer.WriteLine(payload);
|
|
|
|
var readTask = reader.ReadLineAsync();
|
|
if (!readTask.Wait(_timeout))
|
|
{
|
|
_logger.LogWarning("Compactor pipe timed out waiting for response.");
|
|
return false;
|
|
}
|
|
|
|
var line = readTask.Result;
|
|
if (string.IsNullOrWhiteSpace(line))
|
|
return false;
|
|
|
|
try
|
|
{
|
|
response = JsonSerializer.Deserialize<CompactorResponse>(line);
|
|
return response is not null;
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
_logger.LogDebug(ex, "Failed to parse compactor response.");
|
|
return false;
|
|
}
|
|
}
|
|
|
|
private string? ResolveWorkerPath()
|
|
{
|
|
var baseDir = AppContext.BaseDirectory;
|
|
var exeName = OperatingSystem.IsWindows() || _context.IsWine
|
|
? "LightlessCompactorWorker.exe"
|
|
: "LightlessCompactorWorker";
|
|
var path = Path.Combine(baseDir, exeName);
|
|
return File.Exists(path) ? path : null;
|
|
}
|
|
|
|
private string BuildArguments()
|
|
{
|
|
var args = new List<string> { "--pipe", Quote(_pipeName), "--parent", Environment.ProcessId.ToString() };
|
|
if (_context.IsWine)
|
|
args.Add("--wine");
|
|
return string.Join(' ', args);
|
|
}
|
|
|
|
private static string Quote(string value)
|
|
{
|
|
if (string.IsNullOrEmpty(value))
|
|
return "\"\"";
|
|
|
|
if (!value.Contains('"', StringComparison.Ordinal))
|
|
return "\"" + value + "\"";
|
|
|
|
return "\"" + value.Replace("\"", "\\\"", StringComparison.Ordinal) + "\"";
|
|
}
|
|
|
|
private static void TrySetLowPriority(Process process)
|
|
{
|
|
try
|
|
{
|
|
if (OperatingSystem.IsWindows())
|
|
process.PriorityClass = ProcessPriorityClass.BelowNormal;
|
|
}
|
|
catch
|
|
{
|
|
// ignore
|
|
}
|
|
}
|
|
|
|
private async Task DrainAsync(StreamReader reader, string label)
|
|
{
|
|
try
|
|
{
|
|
string? line;
|
|
while ((line = await reader.ReadLineAsync().ConfigureAwait(false)) != null)
|
|
{
|
|
if (_logger.IsEnabled(LogLevel.Trace))
|
|
_logger.LogTrace("Compactor {label}: {line}", label, line);
|
|
}
|
|
}
|
|
catch
|
|
{
|
|
// ignore
|
|
}
|
|
}
|
|
|
|
private static void TryKill(Process process)
|
|
{
|
|
try
|
|
{
|
|
process.Kill(entireProcessTree: true);
|
|
}
|
|
catch
|
|
{
|
|
// ignore
|
|
}
|
|
}
|
|
|
|
private sealed class CompactorRequest
|
|
{
|
|
public string Type { get; init; } = "compact";
|
|
public string? Path { get; init; }
|
|
}
|
|
|
|
private sealed class CompactorResponse
|
|
{
|
|
public bool Success { get; init; }
|
|
public string? Error { get; init; }
|
|
}
|
|
}
|