removal of *temporary* collections

LightlessSync/PlayerData/Factories/PlayerDataFactory.cs

@@ -257,7 +257,28 @@ public class PlayerDataFactory
             getMoodlesData = _ipcManager.Moodles.GetStatusAsync(playerRelatedObject.Address);
         }
 
-        var resolvedPaths = await _ipcManager.Penumbra.GetCharacterData(_logger, playerRelatedObject).ConfigureAwait(false) ?? throw new InvalidOperationException("Penumbra returned null data; couldn't proceed with character");
+        Guid penumbraRequestId = Guid.Empty;
+        Stopwatch? penumbraSw = null;
+        if (logDebug)
+        {
+            penumbraRequestId = Guid.NewGuid();
+            penumbraSw = Stopwatch.StartNew();
+            _logger.LogDebug("Penumbra GetCharacterData start {id} for {obj}", penumbraRequestId, playerRelatedObject);
+        }
+
+        var resolvedPaths = await _ipcManager.Penumbra.GetCharacterData(_logger, playerRelatedObject).ConfigureAwait(false);
+
+        if (logDebug)
+        {
+            penumbraSw!.Stop();
+            _logger.LogDebug("Penumbra GetCharacterData done {id} in {elapsedMs}ms (count={count})",
+                penumbraRequestId,
+                penumbraSw.ElapsedMilliseconds,
+                resolvedPaths?.Count ?? -1);
+        }
+
+        if (resolvedPaths == null)
+            throw new InvalidOperationException("Penumbra returned null data; couldn't proceed with character");
         ct.ThrowIfCancellationRequested();
 
         var staticBuildTask = Task.Run(() => BuildStaticReplacements(resolvedPaths), ct);

LightlessSync/PlayerData/Pairs/IPairHandlerAdapter.cs

@@ -30,8 +30,6 @@ public interface IPairHandlerAdapter : IDisposable, IPairPerformanceSubject
     int MissingCriticalMods { get; }
     int MissingNonCriticalMods { get; }
     int MissingForbiddenMods { get; }
-    DateTime? InvisibleSinceUtc { get; }
-    DateTime? VisibilityEvictionDueAtUtc { get; }
 
     void Initialize();
     void ApplyData(CharacterData data);

LightlessSync/PlayerData/Pairs/Pair.cs

@@ -217,12 +217,6 @@ public class Pair
         if (handler is null)
             return PairDebugInfo.Empty;
 
-        var now = DateTime.UtcNow;
-        var dueAt = handler.VisibilityEvictionDueAtUtc;
-        var remainingSeconds = dueAt.HasValue
-            ? Math.Max(0, (dueAt.Value - now).TotalSeconds)
-            : (double?)null;
-
         return new PairDebugInfo(
             true,
             handler.Initialized,
@@ -231,9 +225,6 @@ public class Pair
             handler.LastDataReceivedAt,
             handler.LastApplyAttemptAt,
             handler.LastSuccessfulApplyAt,
-            handler.InvisibleSinceUtc,
-            handler.VisibilityEvictionDueAtUtc,
-            remainingSeconds,
             handler.LastFailureReason,
             handler.LastBlockingConditions,
             handler.IsApplying,

LightlessSync/PlayerData/Pairs/PairDebugInfo.cs

@@ -8,9 +8,6 @@ public sealed record PairDebugInfo(
     DateTime? LastDataReceivedAt,
     DateTime? LastApplyAttemptAt,
     DateTime? LastSuccessfulApplyAt,
-    DateTime? InvisibleSinceUtc,
-    DateTime? VisibilityEvictionDueAtUtc,
-    double? VisibilityEvictionRemainingSeconds,
     string? LastFailureReason,
     IReadOnlyList<string> BlockingConditions,
     bool IsApplying,
@@ -32,9 +29,6 @@ public sealed record PairDebugInfo(
         null,
         null,
         null,
-        null,
-        null,
-        null,
         Array.Empty<string>(),
         false,
         false,