From 94f520d0e7ec14500581704e9ccbeb8faa4899f2 Mon Sep 17 00:00:00 2001
From: defnotken <defnotken@noreply.git.lightless-sync.org>
Date: Sun, 28 Dec 2025 15:13:40 +0000
Subject: [PATCH] Add Serious Warning about nameplates (#118)

Co-authored-by: defnotken <itsdefnotken@gmail.com>
Reviewed-on: https://git.lightless-sync.org/Lightless-Sync/LightlessClient/pulls/118
Co-authored-by: defnotken <defnotken@noreply.git.lightless-sync.org>
Co-committed-by: defnotken <defnotken@noreply.git.lightless-sync.org>
---
 LightlessSync/UI/SettingsUi.cs | 49 +++++++++++++++++++++++++++++-----
 1 file changed, 43 insertions(+), 6 deletions(-)

diff --git a/LightlessSync/UI/SettingsUi.cs b/LightlessSync/UI/SettingsUi.cs
index a0c1787..1c86580 100644
--- a/LightlessSync/UI/SettingsUi.cs
+++ b/LightlessSync/UI/SettingsUi.cs
@@ -84,6 +84,8 @@ public class SettingsUi : WindowMediatorSubscriberBase
     private bool _pairDiagnosticsEnabled;
     private string? _selectedPairDebugUid = null;
     private string _lightfinderIconInput = string.Empty;
+    private bool _showLightfinderRendererWarning = false;
+    private LightfinderLabelRenderer _pendingLightfinderRenderer = LightfinderLabelRenderer.Pictomancy;
     private bool _lightfinderIconInputInitialized = false;
     private int _lightfinderIconPresetIndex = -1;
     private static readonly LightlessConfig DefaultConfig = new();
@@ -2372,7 +2374,7 @@ public class SettingsUi : WindowMediatorSubscriberBase
                 var labelRenderer = _configService.Current.LightfinderLabelRenderer;
                 var labelRendererLabel = labelRenderer switch
                 {
-                    LightfinderLabelRenderer.SignatureHook => "Native nameplate (sig hook)",
+                    LightfinderLabelRenderer.SignatureHook => "Native Nameplate Rendering",
                     _ => "ImGui Overlay",
                 };
 
@@ -2382,18 +2384,25 @@ public class SettingsUi : WindowMediatorSubscriberBase
                     {
                         var optionLabel = option switch
                         {
-                            LightfinderLabelRenderer.SignatureHook => "Native Nameplate (sig hook)",
+                            LightfinderLabelRenderer.SignatureHook => "Native Nameplate Rendering",
                             _ => "ImGui Overlay",
                         };
 
                         var selected = option == labelRenderer;
                         if (ImGui.Selectable(optionLabel, selected))
                         {
-                            _configService.Current.LightfinderLabelRenderer = option;
-                            _configService.Save();
-                            _nameplateService.RequestRedraw();
+                            if (option == LightfinderLabelRenderer.SignatureHook)
+                            {
+                                _pendingLightfinderRenderer = option;
+                                _showLightfinderRendererWarning = true;
+                            }
+                            else
+                            {
+                                _configService.Current.LightfinderLabelRenderer = option;
+                                _configService.Save();
+                                _nameplateService.RequestRedraw();
+                            }
                         }
-
                         if (selected)
                             ImGui.SetItemDefaultFocus();
                     }
@@ -2401,6 +2410,34 @@ public class SettingsUi : WindowMediatorSubscriberBase
                     ImGui.EndCombo();
                 }
 
+                if (_showLightfinderRendererWarning)
+                {
+                    ImGui.SetNextWindowSize(new Vector2(450f, 0f), ImGuiCond.Appearing);
+                    ImGui.OpenPopup("Nameplate Warning");
+                }
+
+                if (ImGui.BeginPopupModal("Nameplate Warning", ref _showLightfinderRendererWarning, ImGuiWindowFlags.AlwaysAutoResize))
+                {
+                    ImGui.TextColored(UIColors.Get("DimRed"), "USE AT YOUR RISK!");
+                    ImGui.Spacing();
+                    ImGui.TextWrapped("Writing on to the native Nameplates is known to be unstable and MAY cause crashes. DO NOT REPORT THOSE CRASHES TO DALAMUD. We will also not be supporting Nameplate crashes. You have been warned.");
+                    ImGui.Spacing();
+                    ImGui.TextWrapped("By accepting this warning, you understand that you are using this feature at risk of crashing.");
+                    ImGui.Spacing();
+
+                    var buttonWidth = ImGui.GetContentRegionAvail().X;
+                    if (ImGui.Button("I Understand", new Vector2(buttonWidth, 0)))
+                    {
+                        _configService.Current.LightfinderLabelRenderer = _pendingLightfinderRenderer;
+                        _configService.Save();
+                        _nameplateService.RequestRedraw();
+                        _showLightfinderRendererWarning = false;
+                        ImGui.CloseCurrentPopup();
+                    }
+
+                    ImGui.EndPopup();
+                }
+
                 _uiShared.DrawHelpText("Choose how Lightfinder labels render: the default ImGui overlay or native nameplate nodes via signature hook.");
 
                 UiSharedService.ColoredSeparator(UIColors.Get("LightlessPurpleDefault"), 1.5f);