Added comments, clean-up

LightlessSync/Utils/Crypto.cs

@@ -1,16 +1,15 @@
-using System;
-using System.Collections.Generic;
-using System.IO;
-using System.Security.Cryptography;
+using System.Security.Cryptography;
 using System.Text;
 
 namespace LightlessSync.Utils;
 
 public static class Crypto
 {
+    //This buffersize seems to be the best sweetpoint for Linux and Windows
+    private const int _bufferSize = 65536;
 #pragma warning disable SYSLIB0021 // Type or member is obsolete
 
-    private static readonly Dictionary<(string, ushort), string> _hashListPlayersSHA256 = new();
+    private static readonly Dictionary<(string, ushort), string> _hashListPlayersSHA256 = [];
     private static readonly Dictionary<string, string> _hashListSHA256 = new(StringComparer.Ordinal);
     private static readonly SHA256CryptoServiceProvider _sha256CryptoProvider = new();
 
@@ -23,21 +22,21 @@ public static class Crypto
 
     public static async Task<string> GetFileHashAsync(string filePath, CancellationToken cancellationToken = default)
     {
-        var stream = new FileStream(filePath, FileMode.Open, FileAccess.Read, FileShare.ReadWrite | FileShare.Delete, bufferSize: 65536, options: FileOptions.Asynchronous);
+        var stream = new FileStream(filePath, FileMode.Open, FileAccess.Read, FileShare.ReadWrite | FileShare.Delete, bufferSize: _bufferSize, options: FileOptions.Asynchronous);
         await using (stream.ConfigureAwait(false))
         {
             using var sha1 = SHA1.Create();
 
-        var buffer = new byte[8192];
-        int bytesRead;
-        while ((bytesRead = await stream.ReadAsync(buffer, cancellationToken).ConfigureAwait(false)) > 0)
-        {
-            sha1.TransformBlock(buffer, 0, bytesRead, outputBuffer: null, 0);
-        }
+            var buffer = new byte[8192];
+            int bytesRead;
+            while ((bytesRead = await stream.ReadAsync(buffer, cancellationToken).ConfigureAwait(false)) > 0)
+            {
+                sha1.TransformBlock(buffer, 0, bytesRead, outputBuffer: null, 0);
+            }
 
-        sha1.TransformFinalBlock([], 0, 0);
+            sha1.TransformFinalBlock([], 0, 0);
 
-        return BitConverter.ToString(sha1.Hash!).Replace("-", "", StringComparison.Ordinal);
+            return Convert.ToHexString(sha1.Hash!);
         }
     }