1.12.0 - LightFinder + Bugfixes + Other fixes from 1.11.X (#39)

![image.png](/attachments/c984e826-254e-4ce3-af92-4e795ea717ab)

Lightless 1.12.0 is HERE! In this major update, we are introducing something we've been working on and testing for the last couple of weeks. In this update we are introducing a new (**OPTIONAL**) feature called **LightFinder**! We took inspiration from FFXIV's very own Party Finder and decided to implement something that allows users to not only look for fellow Lightless users, but also put up their Syncshell for others looking to join a sync community!

When you enable LightFinder, you will be visible to other LightFinder users for **3 hours** or when you want to disabled it. When the 3 hours are up, you can either leave it disabled or enable it again for another 3 hours. The tag shown above will show above your nameplate, and you will be able to receive pair requests in your UI from other users with LightFinder enabled without having to input their uid!

![image.png](/attachments/91a7ce60-7771-49d7-bae8-6d7a67e46fa3)

Are you at a Venue? In Limsa? Partying in the streets of Uldah? If you're looking for fellow Lightless users you can now enable LightFinder and you will be shown to others who also have LightFinder enabled!

Looking for a Syncshell to join? Enable LightFinder to see what SyncShells are available to join!

Want to advertise your Syncshell? Choose the syncshell you want to put up in LightFinder and enable LightFinder.

**IMPORTANT: We want to stress the fact that, if you just want to sync with just your friends and no one else, this does not take that away. No one will know you use Lightless unless you choose to tell them, or use this **OPTIONAL** feature. Your privacy is still maintained if you don't want to use the feature.**

# Major Changes

## LightFinder - **OPTIONAL FEATURE** - **DOES NOT AFFECT YOU IF YOU DON'T WANT TO USE IT**

![image.png](/attachments/9a1e7455-f9b3-4e3a-9ec5-5bc74ed43c26)

* New **OPTIONAL** syncing feature where one can enable something like a Party Finder so that other Lightless users in the area can see you are looking for people to sync with. Enable it by clicking the compass button and then the `Enable LightFinder` button.

![image.png](/attachments/7be5c1fc-439f-43fc-bb1e-8ae32ab5e52e)

* [L] Send Pair Request has been added to player context menus. You should still be able to send a request without Lightfinder on BUT you will need to know the other player is using Lightless and have them send a pair request back.

![image.png](/attachments/75e0d600-baf9-43d5-af37-e86b6a1e209b)

* When in LightFinder mode, for X mins you will be visible to all Lightless Users WHO ALSO HAVE LIGHTFINDER ON and will receive notifications of people wanting to pair with you. If you are the person using LightFinder, you understand the risks of pairing with someone you don't know. If you are the person sending a request to someone with LightFinder on, you also understand the risks of pairing with someone you don't know. **AGAIN, THIS IS OPTIONAL.**

* When in LightFinder mode, you can also put up a Syncshell you own on the Syncshell Finder so that others can easily find it and join. This has to be done prior to enabling LightFinder.

![image.png](/attachments/1929d8e0-778d-4ced-9bf0-f350887980db)

* Syncshell Finder allows you to join Syncshells that are indexed by LightFinder

![image.png](/attachments/fef7b786-b1a0-4967-a4a9-886cdddc1a61)

# Minor Changes

* Vanity addition to our supporters: On top of vanity ids you can find a fun addition under Your User Settings -> Edit Lightless Profile -> Vanity Settings to change the colour of your name in the lightless ui. This will be shown to all users.
![image.png](/attachments/9b950c07-6b27-4bd1-a0d4-5346396b23e2)

* Pairing nameplate colour override can also now override FC tag (new option_

* Bunch of UI fixes, updates, and changes

* kdb is now a whitelisted filetype that can upload

Co-authored-by: CakeAndBanana <admin@cakeandbanana.nl>
Co-authored-by: azyges <aaaaaa@aaa.aaa>
Co-authored-by: choco <thijmenhogenkamp@gmail.com>
Co-authored-by: choco <choco@noreply.git.lightless-sync.org>
Co-authored-by: defnotken <itsdefnotken@gmail.com>
Reviewed-on: #39

LightlessSync/UI/TopTabMenu.cs

@@ -5,10 +5,18 @@ using Dalamud.Interface.Utility.Raii;
 using Dalamud.Utility;
 using LightlessSync.API.Data.Enum;
 using LightlessSync.API.Data.Extensions;
+using LightlessSync.LightlessConfiguration.Models;
 using LightlessSync.PlayerData.Pairs;
+using LightlessSync.Services;
 using LightlessSync.Services.Mediator;
+using LightlessSync.Utils;
 using LightlessSync.WebAPI;
+using Serilog;
+using System;
+using System.Collections.Generic;
 using System.Numerics;
+using System.Reflection.Emit;
+using System.Threading.Tasks;
 
 namespace LightlessSync.UI;
 
@@ -19,18 +27,25 @@ public class TopTabMenu
     private readonly LightlessMediator _lightlessMediator;
 
     private readonly PairManager _pairManager;
+    private readonly PairRequestService _pairRequestService;
+    private readonly DalamudUtilService _dalamudUtilService;
+    private readonly HashSet<string> _pendingPairRequestActions = new(StringComparer.Ordinal);
+    private bool _pairRequestsExpanded; // useless for now
+    private int _lastRequestCount;
     private readonly UiSharedService _uiSharedService;
     private string _filter = string.Empty;
     private int _globalControlCountdown = 0;
-
+    private float _pairRequestsHeight = 150f;
     private string _pairToAdd = string.Empty;
 
     private SelectedTab _selectedTab = SelectedTab.None;
-    public TopTabMenu(LightlessMediator lightlessMediator, ApiController apiController, PairManager pairManager, UiSharedService uiSharedService)
+    public TopTabMenu(LightlessMediator lightlessMediator, ApiController apiController, PairManager pairManager, UiSharedService uiSharedService, PairRequestService pairRequestService, DalamudUtilService dalamudUtilService)
     {
         _lightlessMediator = lightlessMediator;
         _apiController = apiController;
         _pairManager = pairManager;
+        _pairRequestService = pairRequestService;
+        _dalamudUtilService = dalamudUtilService;
         _uiSharedService = uiSharedService;
     }
 
@@ -39,8 +54,9 @@ public class TopTabMenu
         None,
         Individual,
         Syncshell,
-        Filter,
-        UserConfig
+        Lightfinder,
+        UserConfig,
+        Settings
     }
 
     public string Filter
@@ -60,11 +76,6 @@ public class TopTabMenu
     {
         get => _selectedTab; set
         {
-            if (_selectedTab == SelectedTab.Filter && value != SelectedTab.Filter)
-            {
-                Filter = string.Empty;
-            }
-
             _selectedTab = value;
         }
     }
@@ -72,11 +83,11 @@ public class TopTabMenu
     {
         var availableWidth = ImGui.GetWindowContentRegionMax().X - ImGui.GetWindowContentRegionMin().X;
         var spacing = ImGui.GetStyle().ItemSpacing;
-        var buttonX = (availableWidth - (spacing.X * 3)) / 4f;
+        var buttonX = (availableWidth - (spacing.X * 4)) / 5f;
         var buttonY = _uiSharedService.GetIconButtonSize(FontAwesomeIcon.Pause).Y;
         var buttonSize = new Vector2(buttonX, buttonY);
         var drawList = ImGui.GetWindowDrawList();
-        var underlineColor = ImGui.GetColorU32(ImGuiCol.Separator);
+        var underlineColor = ImGui.GetColorU32(UIColors.Get("LightlessPurpleActive")); // ImGui.GetColorU32(ImGuiCol.Separator);
         var btncolor = ImRaii.PushColor(ImGuiCol.Button, ImGui.ColorConvertFloat4ToU32(new(0, 0, 0, 0)));
 
         ImGuiHelpers.ScaledDummy(spacing.Y / 2f);
@@ -117,19 +128,19 @@ public class TopTabMenu
         using (ImRaii.PushFont(UiBuilder.IconFont))
         {
             var x = ImGui.GetCursorScreenPos();
-            if (ImGui.Button(FontAwesomeIcon.Filter.ToIconString(), buttonSize))
+            if (ImGui.Button(FontAwesomeIcon.Compass.ToIconString(), buttonSize))
             {
-                TabSelection = TabSelection == SelectedTab.Filter ? SelectedTab.None : SelectedTab.Filter;
+                TabSelection = TabSelection == SelectedTab.Lightfinder ? SelectedTab.None : SelectedTab.Lightfinder;
             }
 
             ImGui.SameLine();
             var xAfter = ImGui.GetCursorScreenPos();
-            if (TabSelection == SelectedTab.Filter)
+            if (TabSelection == SelectedTab.Lightfinder)
                 drawList.AddLine(x with { Y = x.Y + buttonSize.Y + spacing.Y },
                     xAfter with { Y = xAfter.Y + buttonSize.Y + spacing.Y, X = xAfter.X - spacing.X },
                     underlineColor, 2);
         }
-        UiSharedService.AttachToolTip("Filter");
+        UiSharedService.AttachToolTip("Lightfinder");
 
         ImGui.SameLine();
         using (ImRaii.PushFont(UiBuilder.IconFont))
@@ -149,6 +160,18 @@ public class TopTabMenu
         }
         UiSharedService.AttachToolTip("Your User Menu");
 
+        ImGui.SameLine();
+        using (ImRaii.PushFont(UiBuilder.IconFont))
+        {
+            var x = ImGui.GetCursorScreenPos();
+            if (ImGui.Button(FontAwesomeIcon.Cog.ToIconString(), buttonSize))
+            {
+                _lightlessMediator.Publish(new UiToggleMessage(typeof(SettingsUi)));
+            }
+            ImGui.SameLine();
+        }
+        UiSharedService.AttachToolTip("Open Lightless Settings");
+
         ImGui.NewLine();
         btncolor.Dispose();
 
@@ -164,9 +187,9 @@ public class TopTabMenu
             DrawSyncshellMenu(availableWidth, spacing.X);
             DrawGlobalSyncshellButtons(availableWidth, spacing.X);
         }
-        else if (TabSelection == SelectedTab.Filter)
+        else if (TabSelection == SelectedTab.Lightfinder)
         {
-            DrawFilter(availableWidth, spacing.X);
+            DrawLightfinderMenu(availableWidth, spacing.X);
         }
         else if (TabSelection == SelectedTab.UserConfig)
         {
@@ -174,7 +197,25 @@ public class TopTabMenu
         }
 
         if (TabSelection != SelectedTab.None) ImGuiHelpers.ScaledDummy(3f);
+
+        #if DEBUG
+        if (ImGui.Button("Add Test Pair Request"))
+        {
+            var fakeCid = Guid.NewGuid().ToString("N");
+            var display = _pairRequestService.RegisterIncomingRequest(fakeCid, "Debug pair request");
+            _lightlessMediator.Publish(new NotificationMessage(
+                "Pair request received (debug)",
+                display.Message,
+                NotificationType.Info,
+                TimeSpan.FromSeconds(5)));
+        }
+        #endif
+
+        DrawIncomingPairRequests(availableWidth);
+
         ImGui.Separator();
+
+        DrawFilter(availableWidth, spacing.X);
     }
 
     private void DrawAddPair(float availableXWidth, float spacingX)
@@ -195,6 +236,207 @@ public class TopTabMenu
         UiSharedService.AttachToolTip("Pair with " + (_pairToAdd.IsNullOrEmpty() ? "other user" : _pairToAdd));
     }
 
+    private void DrawIncomingPairRequests(float availableWidth)
+    {
+        var requests = _pairRequestService.GetActiveRequests();
+        var count = requests.Count;
+        if (count == 0)
+        {
+            _pairRequestsExpanded = false;
+            _lastRequestCount = 0;
+            return;
+        }
+
+        if (count > _lastRequestCount)
+        {
+            _pairRequestsExpanded = true;
+        }
+        _lastRequestCount = count;
+
+        var label = $"Incoming Pair Requests - {count}##IncomingPairRequestsHeader";
+
+        using (ImRaii.PushColor(ImGuiCol.Header, UIColors.Get("LightlessPurple")))
+        using (ImRaii.PushColor(ImGuiCol.HeaderHovered, UIColors.Get("LightlessPurpleActive")))
+        using (ImRaii.PushColor(ImGuiCol.HeaderActive, UIColors.Get("LightlessPurple")))
+        {
+            bool open = ImGui.CollapsingHeader(label, ImGuiTreeNodeFlags.DefaultOpen);
+            _pairRequestsExpanded = open;
+
+            if (ImGui.IsItemHovered())
+                UiSharedService.AttachToolTip("Expand to view incoming pair requests.");
+
+            if (open)
+            {
+                var lineHeight = ImGui.GetTextLineHeightWithSpacing();
+                //var desiredHeight = Math.Clamp(count * lineHeight * 2f, 130f * ImGuiHelpers.GlobalScale, 185f * ImGuiHelpers.GlobalScale); we use resize bar instead
+
+                ImGui.SetCursorPosX(ImGui.GetCursorPosX() - 2f);
+
+                using (ImRaii.PushColor(ImGuiCol.ChildBg, UIColors.Get("LightlessPurple")))
+                using (ImRaii.PushStyle(ImGuiStyleVar.ChildRounding, 6f))
+                {
+                    if (ImGui.BeginChild("##IncomingPairRequestsOuter", new Vector2(availableWidth + 5f, _pairRequestsHeight), true))
+                    {
+                        var defaultChildBg = ImGui.GetStyle().Colors[(int)ImGuiCol.WindowBg];
+                        using (ImRaii.PushColor(ImGuiCol.ChildBg, defaultChildBg))
+                        using (ImRaii.PushStyle(ImGuiStyleVar.ChildRounding, 5f))
+                        using (ImRaii.PushStyle(ImGuiStyleVar.WindowPadding, new Vector2(6, 6)))
+                        {
+                            if (ImGui.BeginChild("##IncomingPairRequestsInner", new Vector2(0, 0), true))
+                            {
+                                using (ImRaii.PushColor(ImGuiCol.TableBorderStrong, ImGui.GetStyle().Colors[(int)ImGuiCol.Border]))
+                                using (ImRaii.PushColor(ImGuiCol.TableBorderLight, ImGui.GetStyle().Colors[(int)ImGuiCol.Border]))
+                                {
+                                    DrawPairRequestList(requests);
+                                }
+                            }
+                            ImGui.EndChild();
+                        }
+                    }
+                    ImGui.EndChild();
+
+                    ImGui.PushStyleColor(ImGuiCol.Button, UIColors.Get("ButtonDefault"));
+                    ImGui.PushStyleColor(ImGuiCol.ButtonHovered, UIColors.Get("LightlessPurple"));
+                    ImGui.PushStyleColor(ImGuiCol.ButtonActive, UIColors.Get("LightlessPurpleActive"));
+                    ImGui.Button("##resizeHandle", new Vector2(availableWidth, 4f));
+                    ImGui.PopStyleColor(3);
+
+                    if (ImGui.IsItemActive())
+                    {
+                        _pairRequestsHeight += ImGui.GetIO().MouseDelta.Y;
+                        _pairRequestsHeight = Math.Clamp(_pairRequestsHeight, 100f, 300f);
+                    }
+                }
+            }
+        }
+    }
+
+    private void DrawPairRequestList(IReadOnlyList<PairRequestService.PairRequestDisplay> requests)
+    {
+        float playerColWidth = 207f * ImGuiHelpers.GlobalScale;
+        float receivedColWidth = 73f * ImGuiHelpers.GlobalScale;
+        float actionsColWidth = 50f * ImGuiHelpers.GlobalScale;
+
+        ImGui.Separator();
+        ImGui.TextUnformatted("Player");
+        ImGui.SameLine(playerColWidth + 2f);
+        ImGui.TextUnformatted("Received");
+        ImGui.SameLine(playerColWidth + receivedColWidth + 12f);
+        ImGui.TextUnformatted("Actions");
+        ImGui.Separator();
+
+        foreach (var request in requests)
+        {
+            ImGui.BeginGroup();
+
+            var label = string.IsNullOrEmpty(request.DisplayName) ? request.HashedCid : request.DisplayName;
+
+            ImGui.TextUnformatted(label.Truncate(26));
+            if (ImGui.IsItemHovered())
+            {
+                ImGui.BeginTooltip();
+                ImGui.TextUnformatted(label);
+                ImGui.EndTooltip();
+            }
+
+            ImGui.SameLine(playerColWidth);
+
+            ImGui.TextUnformatted(GetRelativeTime(request.ReceivedAt));
+            ImGui.SameLine(playerColWidth + receivedColWidth);
+
+            DrawPairRequestActions(request);
+
+            ImGui.EndGroup();
+        }
+    }
+
+    private void DrawPairRequestActions(PairRequestService.PairRequestDisplay request)
+    {
+        using var id = ImRaii.PushId(request.HashedCid);
+        var label = string.IsNullOrEmpty(request.DisplayName) ? request.HashedCid : request.DisplayName;
+        var inFlight = _pendingPairRequestActions.Contains(request.HashedCid);
+        using (ImRaii.Disabled(inFlight))
+        {
+            if (_uiSharedService.IconButton(FontAwesomeIcon.Check))
+            {
+                _ = AcceptPairRequestAsync(request);
+            }
+            if (ImGui.IsItemHovered())
+                ImGui.SetTooltip("Accept request");
+
+            ImGui.SameLine();
+
+            if (_uiSharedService.IconButton(FontAwesomeIcon.Times))
+            {
+                RejectPairRequest(request.HashedCid, label);
+            }
+            if (ImGui.IsItemHovered())
+                ImGui.SetTooltip("Decline request");
+        }
+    }
+
+    private static string GetRelativeTime(DateTime receivedAt)
+    {
+        var delta = DateTime.UtcNow - receivedAt;
+        if (delta <= TimeSpan.FromSeconds(10))
+        {
+            return "Just now";
+        }
+
+        if (delta.TotalMinutes >= 1)
+        {
+            return $"{Math.Floor(delta.TotalMinutes)}m {delta.Seconds:D2}s ago";
+        }
+
+        return $"{delta.Seconds}s ago";
+    }
+
+    private async Task AcceptPairRequestAsync(PairRequestService.PairRequestDisplay request)
+    {
+        if (!_pendingPairRequestActions.Add(request.HashedCid))
+        {
+            return;
+        }
+
+        try
+        {
+            var myCidHash = (await _dalamudUtilService.GetCIDAsync().ConfigureAwait(false)).ToString().GetHash256();
+            await _apiController.TryPairWithContentId(request.HashedCid, myCidHash).ConfigureAwait(false);
+            _pairRequestService.RemoveRequest(request.HashedCid);
+
+            var display = string.IsNullOrEmpty(request.DisplayName) ? request.HashedCid : request.DisplayName;
+            _lightlessMediator.Publish(new NotificationMessage(
+                "Pair request accepted",
+                $"Sent a pair request back to {display}.",
+                NotificationType.Info,
+                TimeSpan.FromSeconds(3)));
+        }
+        catch (Exception ex)
+        {
+            _lightlessMediator.Publish(new NotificationMessage(
+                "Failed to accept pair request",
+                ex.Message,
+                NotificationType.Error,
+                TimeSpan.FromSeconds(5)));
+        }
+        finally
+        {
+            _pendingPairRequestActions.Remove(request.HashedCid);
+        }
+    }
+
+    private void RejectPairRequest(string hashedCid, string playerName)
+    {
+        if (!_pairRequestService.RemoveRequest(hashedCid))
+        {
+            return;
+        }
+
+        _lightlessMediator.Publish(new NotificationMessage("Pair request declined", "Declined " + playerName + "'s pending pair request.",
+            NotificationType.Info,
+            TimeSpan.FromSeconds(3)));
+    }
+
     private void DrawFilter(float availableWidth, float spacingX)
     {
         var buttonSize = _uiSharedService.GetIconTextButtonSize(FontAwesomeIcon.Ban, "Clear");
@@ -483,6 +725,23 @@ public class TopTabMenu
         }
     }
 
+    private void DrawLightfinderMenu(float availableWidth, float spacingX)
+    {
+        var buttonX = (availableWidth - (spacingX)) / 2f;
+
+        if (_uiSharedService.IconTextButton(FontAwesomeIcon.PersonCirclePlus, "Lightfinder", buttonX, center: true))
+        {
+            _lightlessMediator.Publish(new UiToggleMessage(typeof(BroadcastUI)));
+        }
+
+        ImGui.SameLine();
+
+        if (_uiSharedService.IconTextButton(FontAwesomeIcon.Globe, "Syncshell Finder", buttonX, center: true))
+        {
+            _lightlessMediator.Publish(new UiToggleMessage(typeof(SyncshellFinderUI)));
+        }
+    }
+
     private void DrawUserConfig(float availableWidth, float spacingX)
     {
         var buttonX = (availableWidth - spacingX) / 2f;