up to date with 2.0.3
This commit is contained in:
@@ -3,6 +3,7 @@ using FFXIVClientStructs.FFXIV.Client.Graphics.Scene;
|
||||
using FFXIVClientStructs.Havok.Common.Serialize.Resource;
|
||||
using FFXIVClientStructs.Havok.Animation;
|
||||
using FFXIVClientStructs.Havok.Common.Base.Types;
|
||||
using FFXIVClientStructs.Havok.Common.Serialize.Resource;
|
||||
using FFXIVClientStructs.Havok.Common.Serialize.Util;
|
||||
using LightlessSync.FileCache;
|
||||
using LightlessSync.Interop.GameModel;
|
||||
@@ -10,6 +11,7 @@ using LightlessSync.LightlessConfiguration;
|
||||
using LightlessSync.PlayerData.Factories;
|
||||
using LightlessSync.PlayerData.Handlers;
|
||||
using Microsoft.Extensions.Logging;
|
||||
using OtterGui.Text.EndObjects;
|
||||
using System.Collections.Concurrent;
|
||||
using System.Runtime.InteropServices;
|
||||
using System.Text.RegularExpressions;
|
||||
@@ -130,356 +132,135 @@ public sealed partial class XivDataAnalyzer
|
||||
return (output.Count != 0 && output.Values.All(v => v.Count > 0)) ? output : null;
|
||||
}
|
||||
|
||||
public unsafe Dictionary<string, List<ushort>>? GetBoneIndicesFromPap(string hash, bool persistToConfig = true)
|
||||
public static byte[]? ReadHavokBytesFromPap(string papPath)
|
||||
{
|
||||
if (string.IsNullOrWhiteSpace(hash))
|
||||
return null;
|
||||
|
||||
if (_configService.Current.BonesDictionary.TryGetValue(hash, out var cached) && cached is not null)
|
||||
return cached;
|
||||
|
||||
var cacheEntity = _fileCacheManager.GetFileCacheByHash(hash);
|
||||
if (cacheEntity == null || string.IsNullOrEmpty(cacheEntity.ResolvedFilepath) || !File.Exists(cacheEntity.ResolvedFilepath))
|
||||
return null;
|
||||
|
||||
using var fs = File.Open(cacheEntity.ResolvedFilepath, FileMode.Open, FileAccess.Read, FileShare.Read);
|
||||
using var fs = File.Open(papPath, FileMode.Open, FileAccess.Read, FileShare.Read);
|
||||
using var reader = new BinaryReader(fs);
|
||||
|
||||
// PAP header (mostly from vfxeditor)
|
||||
try
|
||||
{
|
||||
_ = reader.ReadInt32(); // ignore
|
||||
_ = reader.ReadInt32(); // ignore
|
||||
var numAnimations = reader.ReadInt16(); // num animations
|
||||
var modelId = reader.ReadInt16(); // modelid
|
||||
_ = reader.ReadInt32();
|
||||
_ = reader.ReadInt32();
|
||||
_ = reader.ReadInt16();
|
||||
_ = reader.ReadInt16();
|
||||
|
||||
if (numAnimations < 0 || numAnimations > 1000)
|
||||
{
|
||||
_logger.LogWarning("PAP file {hash} has invalid animation count {count}, skipping", hash, numAnimations);
|
||||
return null;
|
||||
}
|
||||
var type = reader.ReadByte();
|
||||
if (type != 0) return null;
|
||||
|
||||
var type = reader.ReadByte(); // type
|
||||
if (type != 0)
|
||||
return null; // not human
|
||||
_ = reader.ReadByte();
|
||||
_ = reader.ReadInt32();
|
||||
|
||||
_ = reader.ReadByte(); // variant
|
||||
_ = reader.ReadInt32(); // ignore
|
||||
var havokPosition = reader.ReadInt32();
|
||||
var footerPosition = reader.ReadInt32();
|
||||
|
||||
var havokPosition = reader.ReadInt32();
|
||||
var footerPosition = reader.ReadInt32();
|
||||
|
||||
if (havokPosition <= 0 || footerPosition <= havokPosition ||
|
||||
footerPosition > fs.Length || havokPosition >= fs.Length)
|
||||
{
|
||||
_logger.LogWarning("PAP file {hash} has invalid offsets (havok={havok}, footer={footer}, length={length})",
|
||||
hash, havokPosition, footerPosition, fs.Length);
|
||||
return null;
|
||||
}
|
||||
|
||||
var havokDataSizeLong = (long)footerPosition - havokPosition;
|
||||
if (havokDataSizeLong <= 8 || havokDataSizeLong > int.MaxValue)
|
||||
{
|
||||
_logger.LogWarning("PAP file {hash} has invalid Havok data size {size}", hash, havokDataSizeLong);
|
||||
return null;
|
||||
}
|
||||
|
||||
var havokDataSize = (int)havokDataSizeLong;
|
||||
|
||||
reader.BaseStream.Position = havokPosition;
|
||||
|
||||
var havokData = new byte[havokDataSize];
|
||||
var bytesRead = reader.Read(havokData, 0, havokDataSize);
|
||||
if (bytesRead != havokDataSize)
|
||||
{
|
||||
_logger.LogWarning("PAP file {hash}: Expected to read {expected} bytes but got {actual}",
|
||||
hash, havokDataSize, bytesRead);
|
||||
return null;
|
||||
}
|
||||
|
||||
if (havokData.Length < 8)
|
||||
return null;
|
||||
|
||||
var tempSets = new Dictionary<string, HashSet<ushort>>(StringComparer.OrdinalIgnoreCase);
|
||||
|
||||
var tempFileName = $"lightless_pap_{Guid.NewGuid():N}_{hash[..Math.Min(8, hash.Length)]}.hkx";
|
||||
var tempHavokDataPath = Path.Combine(Path.GetTempPath(), tempFileName);
|
||||
IntPtr tempHavokDataPathAnsi = IntPtr.Zero;
|
||||
|
||||
try
|
||||
{
|
||||
var tempDir = Path.GetDirectoryName(tempHavokDataPath);
|
||||
if (!Directory.Exists(tempDir))
|
||||
{
|
||||
_logger.LogWarning("Temp directory {dir} doesn't exist", tempDir);
|
||||
return null;
|
||||
}
|
||||
|
||||
// Write the file with explicit error handling
|
||||
try
|
||||
{
|
||||
File.WriteAllBytes(tempHavokDataPath, havokData);
|
||||
}
|
||||
catch (Exception writeEx)
|
||||
{
|
||||
_logger.LogError(writeEx, "Failed to write temporary Havok file to {path}", tempHavokDataPath);
|
||||
return null;
|
||||
}
|
||||
|
||||
if (!File.Exists(tempHavokDataPath))
|
||||
{
|
||||
_logger.LogWarning("Temporary havok file was not created at {path}", tempHavokDataPath);
|
||||
return null;
|
||||
}
|
||||
|
||||
var writtenFileInfo = new FileInfo(tempHavokDataPath);
|
||||
if (writtenFileInfo.Length != havokData.Length)
|
||||
{
|
||||
_logger.LogWarning("Written temp file size mismatch: expected {expected}, got {actual}",
|
||||
havokData.Length, writtenFileInfo.Length);
|
||||
try { File.Delete(tempHavokDataPath); } catch { }
|
||||
return null;
|
||||
}
|
||||
|
||||
Thread.Sleep(10); // stabilize file system
|
||||
|
||||
try
|
||||
{
|
||||
using var testStream = File.OpenRead(tempHavokDataPath);
|
||||
if (testStream.Length != havokData.Length)
|
||||
{
|
||||
_logger.LogWarning("File verification failed: length mismatch after write");
|
||||
try { File.Delete(tempHavokDataPath); } catch { }
|
||||
return null;
|
||||
}
|
||||
}
|
||||
catch (Exception readEx)
|
||||
{
|
||||
_logger.LogError(readEx, "Cannot read back temporary file at {path}", tempHavokDataPath);
|
||||
try { File.Delete(tempHavokDataPath); } catch { }
|
||||
return null;
|
||||
}
|
||||
|
||||
tempHavokDataPathAnsi = Marshal.StringToHGlobalAnsi(tempHavokDataPath);
|
||||
|
||||
var loadoptions = stackalloc hkSerializeUtil.LoadOptions[1];
|
||||
loadoptions->TypeInfoRegistry = hkBuiltinTypeRegistry.Instance()->GetTypeInfoRegistry();
|
||||
loadoptions->ClassNameRegistry = hkBuiltinTypeRegistry.Instance()->GetClassNameRegistry();
|
||||
loadoptions->Flags = new hkFlags<hkSerializeUtil.LoadOptionBits, int>
|
||||
{
|
||||
Storage = (int)hkSerializeUtil.LoadOptionBits.Default
|
||||
};
|
||||
|
||||
hkResource* resource = null;
|
||||
try
|
||||
{
|
||||
if (tempHavokDataPathAnsi == IntPtr.Zero)
|
||||
{
|
||||
_logger.LogError("Failed to allocate ANSI string for path");
|
||||
return null;
|
||||
}
|
||||
|
||||
resource = hkSerializeUtil.LoadFromFile((byte*)tempHavokDataPathAnsi, null, loadoptions);
|
||||
}
|
||||
catch (SEHException ex)
|
||||
{
|
||||
_logger.LogError(ex, "SEH exception loading Havok file from {path} (hash={hash}). Native error code: 0x{code:X}. This may indicate a corrupted PAP file or incompatible Havok format.",
|
||||
tempHavokDataPath, hash, ex.ErrorCode);
|
||||
return null;
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogError(ex, "Unexpected exception loading Havok file from {path} (hash={hash})",
|
||||
tempHavokDataPath, hash);
|
||||
return null;
|
||||
}
|
||||
|
||||
if (resource == null)
|
||||
{
|
||||
_logger.LogDebug("Havok resource was null after loading from {path} (hash={hash}). File may be corrupted or in an unsupported format.",
|
||||
tempHavokDataPath, hash);
|
||||
return null;
|
||||
}
|
||||
|
||||
if ((nint)resource == nint.Zero || !IsValidPointer((IntPtr)resource))
|
||||
{
|
||||
_logger.LogDebug("Havok resource pointer is invalid (hash={hash})", hash);
|
||||
return null;
|
||||
}
|
||||
|
||||
var rootLevelName = @"hkRootLevelContainer"u8;
|
||||
fixed (byte* n1 = rootLevelName)
|
||||
{
|
||||
var container = (hkRootLevelContainer*)resource->GetContentsPointer(n1, hkBuiltinTypeRegistry.Instance()->GetTypeInfoRegistry());
|
||||
if (container == null)
|
||||
{
|
||||
_logger.LogDebug("hkRootLevelContainer is null (hash={hash})", hash);
|
||||
return null;
|
||||
}
|
||||
|
||||
if ((nint)container == nint.Zero || !IsValidPointer((IntPtr)container))
|
||||
{
|
||||
_logger.LogDebug("hkRootLevelContainer pointer is invalid (hash={hash})", hash);
|
||||
return null;
|
||||
}
|
||||
|
||||
var animationName = @"hkaAnimationContainer"u8;
|
||||
fixed (byte* n2 = animationName)
|
||||
{
|
||||
var animContainer = (hkaAnimationContainer*)container->findObjectByName(n2, null);
|
||||
if (animContainer == null)
|
||||
{
|
||||
_logger.LogDebug("hkaAnimationContainer is null (hash={hash})", hash);
|
||||
return null;
|
||||
}
|
||||
|
||||
if ((nint)animContainer == nint.Zero || !IsValidPointer((IntPtr)animContainer))
|
||||
{
|
||||
_logger.LogDebug("hkaAnimationContainer pointer is invalid (hash={hash})", hash);
|
||||
return null;
|
||||
}
|
||||
|
||||
if (animContainer->Bindings.Length < 0 || animContainer->Bindings.Length > 10000)
|
||||
{
|
||||
_logger.LogDebug("Invalid bindings count {count} (hash={hash})", animContainer->Bindings.Length, hash);
|
||||
return null;
|
||||
}
|
||||
|
||||
for (int i = 0; i < animContainer->Bindings.Length; i++)
|
||||
{
|
||||
var binding = animContainer->Bindings[i].ptr;
|
||||
if (binding == null)
|
||||
continue;
|
||||
|
||||
if ((nint)binding == nint.Zero || !IsValidPointer((IntPtr)binding))
|
||||
{
|
||||
_logger.LogDebug("Skipping invalid binding at index {index} (hash={hash})", i, hash);
|
||||
continue;
|
||||
}
|
||||
|
||||
var rawSkel = binding->OriginalSkeletonName.String;
|
||||
var skeletonKey = CanonicalizeSkeletonKey(rawSkel);
|
||||
if (string.IsNullOrEmpty(skeletonKey))
|
||||
continue;
|
||||
|
||||
var boneTransform = binding->TransformTrackToBoneIndices;
|
||||
if (boneTransform.Length <= 0 || boneTransform.Length > 10000)
|
||||
{
|
||||
_logger.LogDebug("Invalid bone transform length {length} for skeleton {skel} (hash={hash})",
|
||||
boneTransform.Length, skeletonKey, hash);
|
||||
continue;
|
||||
}
|
||||
|
||||
if (!tempSets.TryGetValue(skeletonKey, out var set))
|
||||
{
|
||||
set = [];
|
||||
tempSets[skeletonKey] = set;
|
||||
}
|
||||
|
||||
for (int boneIdx = 0; boneIdx < boneTransform.Length; boneIdx++)
|
||||
{
|
||||
var v = boneTransform[boneIdx];
|
||||
if (v < 0 || v > ushort.MaxValue)
|
||||
continue;
|
||||
set.Add((ushort)v);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
catch (SEHException ex)
|
||||
{
|
||||
_logger.LogError(ex, "SEH exception processing PAP file {hash} from {path}. Error code: 0x{code:X}",
|
||||
hash, tempHavokDataPath, ex.ErrorCode);
|
||||
return null;
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogError(ex, "Managed exception loading havok file {hash} from {path}", hash, tempHavokDataPath);
|
||||
return null;
|
||||
}
|
||||
finally
|
||||
{
|
||||
if (tempHavokDataPathAnsi != IntPtr.Zero)
|
||||
Marshal.FreeHGlobal(tempHavokDataPathAnsi);
|
||||
|
||||
int retryCount = 3;
|
||||
while (retryCount > 0 && File.Exists(tempHavokDataPath))
|
||||
{
|
||||
try
|
||||
{
|
||||
File.Delete(tempHavokDataPath);
|
||||
break;
|
||||
}
|
||||
catch (IOException ex)
|
||||
{
|
||||
retryCount--;
|
||||
if (retryCount == 0)
|
||||
{
|
||||
_logger.LogDebug(ex, "Failed to delete temporary havok file after retries: {path}", tempHavokDataPath);
|
||||
}
|
||||
else
|
||||
{
|
||||
Thread.Sleep(50);
|
||||
}
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogDebug(ex, "Unexpected error deleting temporary havok file: {path}", tempHavokDataPath);
|
||||
break;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
if (tempSets.Count == 0)
|
||||
{
|
||||
_logger.LogDebug("No bone sets found in PAP file (hash={hash})", hash);
|
||||
return null;
|
||||
}
|
||||
|
||||
var output = new Dictionary<string, List<ushort>>(tempSets.Count, StringComparer.OrdinalIgnoreCase);
|
||||
foreach (var (key, set) in tempSets)
|
||||
{
|
||||
if (set.Count == 0) continue;
|
||||
|
||||
var list = set.ToList();
|
||||
list.Sort();
|
||||
output[key] = list;
|
||||
}
|
||||
|
||||
if (output.Count == 0)
|
||||
return null;
|
||||
|
||||
_configService.Current.BonesDictionary[hash] = output;
|
||||
|
||||
if (persistToConfig)
|
||||
_configService.Save();
|
||||
|
||||
return output;
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.LogError(ex, "Outer exception reading PAP file (hash={hash})", hash);
|
||||
if (havokPosition <= 0 || footerPosition <= havokPosition || footerPosition > fs.Length)
|
||||
return null;
|
||||
}
|
||||
|
||||
var sizeLong = (long)footerPosition - havokPosition;
|
||||
if (sizeLong <= 8 || sizeLong > int.MaxValue)
|
||||
return null;
|
||||
|
||||
var size = (int)sizeLong;
|
||||
|
||||
fs.Position = havokPosition;
|
||||
var bytes = reader.ReadBytes(size);
|
||||
return bytes.Length > 8 ? bytes : null;
|
||||
}
|
||||
|
||||
private static bool IsValidPointer(IntPtr ptr)
|
||||
public unsafe Dictionary<string, List<ushort>>? ParseHavokBytesOnFrameworkThread(
|
||||
byte[] havokData,
|
||||
string hash,
|
||||
bool persistToConfig)
|
||||
{
|
||||
if (ptr == IntPtr.Zero)
|
||||
return false;
|
||||
var tempSets = new Dictionary<string, HashSet<ushort>>(StringComparer.OrdinalIgnoreCase);
|
||||
|
||||
var tempHkxPath = Path.Combine(Path.GetTempPath(), $"lightless_{Guid.NewGuid():N}.hkx");
|
||||
IntPtr pathAnsi = IntPtr.Zero;
|
||||
|
||||
try
|
||||
{
|
||||
_ = Marshal.ReadByte(ptr);
|
||||
return true;
|
||||
}
|
||||
catch
|
||||
{
|
||||
return false;
|
||||
}
|
||||
}
|
||||
File.WriteAllBytes(tempHkxPath, havokData);
|
||||
|
||||
pathAnsi = Marshal.StringToHGlobalAnsi(tempHkxPath);
|
||||
|
||||
hkSerializeUtil.LoadOptions loadOptions = default;
|
||||
loadOptions.TypeInfoRegistry = hkBuiltinTypeRegistry.Instance()->GetTypeInfoRegistry();
|
||||
loadOptions.ClassNameRegistry = hkBuiltinTypeRegistry.Instance()->GetClassNameRegistry();
|
||||
loadOptions.Flags = new hkFlags<hkSerializeUtil.LoadOptionBits, int>
|
||||
{
|
||||
Storage = (int)hkSerializeUtil.LoadOptionBits.Default
|
||||
};
|
||||
|
||||
hkSerializeUtil.LoadOptions* pOpts = &loadOptions;
|
||||
|
||||
var resource = hkSerializeUtil.LoadFromFile((byte*)pathAnsi, errorResult: null, pOpts);
|
||||
if (resource == null)
|
||||
return null;
|
||||
|
||||
var rootLevelName = @"hkRootLevelContainer"u8;
|
||||
fixed (byte* n1 = rootLevelName)
|
||||
{
|
||||
var container = (hkRootLevelContainer*)resource->GetContentsPointer(
|
||||
n1, hkBuiltinTypeRegistry.Instance()->GetTypeInfoRegistry());
|
||||
|
||||
if (container == null) return null;
|
||||
|
||||
var animationName = @"hkaAnimationContainer"u8;
|
||||
fixed (byte* n2 = animationName)
|
||||
{
|
||||
var animContainer = (hkaAnimationContainer*)container->findObjectByName(n2, null);
|
||||
if (animContainer == null) return null;
|
||||
|
||||
for (int i = 0; i < animContainer->Bindings.Length; i++)
|
||||
{
|
||||
var binding = animContainer->Bindings[i].ptr;
|
||||
if (binding == null) continue;
|
||||
|
||||
var rawSkel = binding->OriginalSkeletonName.String;
|
||||
var skeletonKey = CanonicalizeSkeletonKey(rawSkel);
|
||||
if (string.IsNullOrEmpty(skeletonKey)) continue;
|
||||
|
||||
var boneTransform = binding->TransformTrackToBoneIndices;
|
||||
if (boneTransform.Length <= 0) continue;
|
||||
|
||||
if (!tempSets.TryGetValue(skeletonKey, out var set))
|
||||
tempSets[skeletonKey] = set = [];
|
||||
|
||||
for (int boneIdx = 0; boneIdx < boneTransform.Length; boneIdx++)
|
||||
{
|
||||
var v = boneTransform[boneIdx];
|
||||
if (v < 0) continue;
|
||||
set.Add((ushort)v);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
finally
|
||||
{
|
||||
if (pathAnsi != IntPtr.Zero)
|
||||
Marshal.FreeHGlobal(pathAnsi);
|
||||
|
||||
try { if (File.Exists(tempHkxPath)) File.Delete(tempHkxPath); }
|
||||
catch { /* ignore */ }
|
||||
}
|
||||
|
||||
if (tempSets.Count == 0) return null;
|
||||
|
||||
var output = new Dictionary<string, List<ushort>>(tempSets.Count, StringComparer.OrdinalIgnoreCase);
|
||||
foreach (var (key, set) in tempSets)
|
||||
{
|
||||
if (set.Count == 0) continue;
|
||||
var list = set.ToList();
|
||||
list.Sort();
|
||||
output[key] = list;
|
||||
}
|
||||
|
||||
if (output.Count == 0) return null;
|
||||
|
||||
_configService.Current.BonesDictionary[hash] = output;
|
||||
if (persistToConfig) _configService.Save();
|
||||
|
||||
return output;
|
||||
}
|
||||
|
||||
public static string CanonicalizeSkeletonKey(string? raw)
|
||||
{
|
||||
@@ -558,41 +339,56 @@ public sealed partial class XivDataAnalyzer
|
||||
if (mode == AnimationValidationMode.Unsafe)
|
||||
return true;
|
||||
|
||||
var papBuckets = papBoneIndices.Keys
|
||||
.Select(CanonicalizeSkeletonKey)
|
||||
.Where(k => !string.IsNullOrEmpty(k))
|
||||
.Distinct(StringComparer.OrdinalIgnoreCase)
|
||||
.ToList();
|
||||
var papByBucket = new Dictionary<string, List<ushort>>(StringComparer.OrdinalIgnoreCase);
|
||||
|
||||
if (papBuckets.Count == 0)
|
||||
foreach (var (rawKey, list) in papBoneIndices)
|
||||
{
|
||||
var key = CanonicalizeSkeletonKey(rawKey);
|
||||
if (string.IsNullOrEmpty(key))
|
||||
continue;
|
||||
|
||||
if (string.Equals(key, "skeleton", StringComparison.OrdinalIgnoreCase))
|
||||
key = "__any__";
|
||||
|
||||
if (!papByBucket.TryGetValue(key, out var acc))
|
||||
papByBucket[key] = acc = [];
|
||||
|
||||
if (list is { Count: > 0 })
|
||||
acc.AddRange(list);
|
||||
}
|
||||
|
||||
foreach (var k in papByBucket.Keys.ToList())
|
||||
papByBucket[k] = papByBucket[k].Distinct().ToList();
|
||||
|
||||
if (papByBucket.Count == 0)
|
||||
{
|
||||
reason = "No skeleton bucket bindings found in the PAP";
|
||||
return false;
|
||||
}
|
||||
|
||||
if (mode == AnimationValidationMode.Safe)
|
||||
static bool AllIndicesOk(
|
||||
HashSet<ushort> available,
|
||||
List<ushort> indices,
|
||||
bool papLikelyOneBased,
|
||||
bool allowOneBasedShift,
|
||||
bool allowNeighborTolerance,
|
||||
out ushort missing)
|
||||
{
|
||||
if (papBuckets.Any(b => localBoneSets.ContainsKey(b)))
|
||||
return true;
|
||||
|
||||
reason = $"No matching skeleton bucket between PAP [{string.Join(", ", papBuckets)}] and local [{string.Join(", ", localBoneSets.Keys.Order())}].";
|
||||
return false;
|
||||
}
|
||||
|
||||
foreach (var bucket in papBuckets)
|
||||
{
|
||||
if (!localBoneSets.TryGetValue(bucket, out var available))
|
||||
foreach (var idx in indices)
|
||||
{
|
||||
reason = $"Missing skeleton bucket '{bucket}' on local actor.";
|
||||
return false;
|
||||
if (!ContainsIndexCompat(available, idx, papLikelyOneBased, allowOneBasedShift, allowNeighborTolerance))
|
||||
{
|
||||
missing = idx;
|
||||
return false;
|
||||
}
|
||||
}
|
||||
|
||||
var indices = papBoneIndices
|
||||
.Where(kvp => string.Equals(CanonicalizeSkeletonKey(kvp.Key), bucket, StringComparison.OrdinalIgnoreCase))
|
||||
.SelectMany(kvp => kvp.Value ?? Enumerable.Empty<ushort>())
|
||||
.Distinct()
|
||||
.ToList();
|
||||
missing = 0;
|
||||
return true;
|
||||
}
|
||||
|
||||
foreach (var (bucket, indices) in papByBucket)
|
||||
{
|
||||
if (indices.Count == 0)
|
||||
continue;
|
||||
|
||||
@@ -606,14 +402,32 @@ public sealed partial class XivDataAnalyzer
|
||||
}
|
||||
bool papLikelyOneBased = allowOneBasedShift && (min == 1) && has1 && !has0;
|
||||
|
||||
foreach (var idx in indices)
|
||||
if (string.Equals(bucket, "__any__", StringComparison.OrdinalIgnoreCase))
|
||||
{
|
||||
if (!ContainsIndexCompat(available, idx, papLikelyOneBased, allowOneBasedShift, allowNeighborTolerance))
|
||||
foreach (var (lk, ls) in localBoneSets)
|
||||
{
|
||||
reason = $"No compatible local skeleton for PAP '{bucket}': missing bone index {idx}.";
|
||||
return false;
|
||||
if (AllIndicesOk(ls, indices, papLikelyOneBased, allowOneBasedShift, allowNeighborTolerance, out _))
|
||||
goto nextBucket;
|
||||
}
|
||||
|
||||
reason = $"No compatible local skeleton bucket for generic PAP skeleton '{bucket}'. Local buckets: {string.Join(", ", localBoneSets.Keys)}";
|
||||
return false;
|
||||
}
|
||||
|
||||
if (!localBoneSets.TryGetValue(bucket, out var available))
|
||||
{
|
||||
reason = $"Missing skeleton bucket '{bucket}' on local actor.";
|
||||
return false;
|
||||
}
|
||||
|
||||
if (!AllIndicesOk(available, indices, papLikelyOneBased, allowOneBasedShift, allowNeighborTolerance, out var missing))
|
||||
{
|
||||
reason = $"No compatible local skeleton for PAP '{bucket}': missing bone index {missing}.";
|
||||
return false;
|
||||
}
|
||||
|
||||
nextBucket:
|
||||
;
|
||||
}
|
||||
|
||||
return true;
|
||||
|
||||
Reference in New Issue
Block a user